Avoid some useless allocations in FaultToleranceScanner #45539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
commented
Jan 13, 2025
| ClassInfo beanClass, Set<Class<? extends Annotation>> directlyPresent) { | ||
|
|
||
| DotName annotationName = DotName.createSimple(annotationType); |
There was a problem hiding this comment.
I had an hesitation about adding a safeguard here to check consistency but I would say our tests should cover this?
There was a problem hiding this comment.
This is fine, yes. It's a private method after all :-)
|
I already did this locally, together with a few more improvements in that class. Not sure if I should force-push here? |
|
We can close this if you have further improvements, no worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #45509