Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Take RestMulti headers and status into account when using SSE resource method" #45406

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

@FroMage
Copy link
Member

FroMage commented Jan 7, 2025

Wow. This PR is turning out to be super complex :(

@geoand
Copy link
Contributor Author

geoand commented Jan 7, 2025

Yeah, the subtle issue the PR had was that the empty buffer is sent too late...

@geoand geoand requested a review from rsvoboda January 7, 2025 12:49
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 7, 2025
Copy link

quarkus-bot bot commented Jan 7, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 70078e0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.VertxBlockingRawTest.shouldAdd - History

  • Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

@geoand geoand merged commit e48292f into main Jan 7, 2025
88 of 89 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 7, 2025
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jan 7, 2025
@geoand geoand deleted the revert-44903-test/sse-response-header-test branch January 7, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

context-propagation-quickstart fails after "Use MethodHandle" changes
3 participants