Docs: Correct sentence in Using the MongoDB Client #45387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Jan 6, 2025
docs/src/main/asciidoc/mongodb.adoc
Outdated
| @@ -217,7 +217,7 @@ public class FruitResource { | |||
| The implementation is pretty straightforward, and you just need to define your endpoints using the Jakarta REST annotations and use the `FruitService` to list/add new fruits. | |||
|
|
|||
| == Configuring the MongoDB database | |||
| The main property to configure is the URL to access to MongoDB. Almost all configuration can be included in the connection URI, so we advise you to do so. You can find more information in the MongoDB documentation: https://docs.mongodb.com/manual/reference/connection-string/ | |||
| The main property to configure is the URL to access the MongoDB. Almost all configuration can be included in the connection URI, so we advise you to do so. You can find more information in the MongoDB documentation: https://docs.mongodb.com/manual/reference/connection-string/ | |||
There was a problem hiding this comment.
Thanks! I think it would be better with:
Suggested change
| The main property to configure is the URL to access the MongoDB. Almost all configuration can be included in the connection URI, so we advise you to do so. You can find more information in the MongoDB documentation: https://docs.mongodb.com/manual/reference/connection-string/ | |
| The main property to configure is the URL to access MongoDB. Almost all configuration can be included in the connection URI, so we advise you to do so. You can find more information in the MongoDB documentation: https://docs.mongodb.com/manual/reference/connection-string/ |
(or the MongoDB server or the MongoDB instance)
Could you adjust and squash?
Thanks!
Signed-off-by: Maciej Lisowski <[email protected]>
MaciejDromin
force-pushed
the
mongodb-client-sentence-fix
branch
from
9ad30a8 to
a200a47
Compare
This comment has been minimized.
This comment has been minimized.
|
🙈 The PR is closed and the preview is expired. |
Status for workflow
|
gsmet
approved these changes
Jan 7, 2025
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the docs I stumbled across weird sentence in Using the MongoDB Client.
This PR is simply changing this weird sentence.