Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to create static OIDC tenants programmatically #45294

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Allow to create static OIDC tenants programmatically #45294

merged 1 commit into from
Jan 1, 2025

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Dec 26, 2024 •
edited
Loading

  • closes: Programmatic OIDC startup #44958
  • allows to programmatically configure static OIDC tenants; there are features restricted to static tenants (like issuer-based and path-based tenant resolvers) can use tenants created like OidcTenantConfig.authServerUrl("...").build()

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation area/keycloak area/oidc labels Dec 26, 2024
@michalvavrik michalvavrik force-pushed the feature/programmatic-oidc-startup branch 2 times, most recently from 9c5f494 to 170f753 Compare December 26, 2024 21:16
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@michalvavrik michalvavrik force-pushed the feature/programmatic-oidc-startup branch from 170f753 to 1b4601d Compare December 26, 2024 21:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 26, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@michalvavrik michalvavrik force-pushed the feature/programmatic-oidc-startup branch 2 times, most recently from 2bd44e1 to 536ac21 Compare December 28, 2024 16:33
@michalvavrik michalvavrik changed the title Allow to create OIDC tenants programmatically Allow to create static OIDC tenants programmatically Dec 28, 2024
@michalvavrik michalvavrik force-pushed the feature/programmatic-oidc-startup branch 2 times, most recently from b510be4 to c428e8b Compare December 28, 2024 17:02
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
sberyozkin
sberyozkin reviewed Dec 29, 2024
View reviewed changes
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michal, IMHO, another brilliant piece of work, with a very big impact. Thanks a million, let's tune a few minor details and it will be ready to go

@michalvavrik michalvavrik force-pushed the feature/programmatic-oidc-startup branch from c428e8b to a6cbd2d Compare December 30, 2024 00:16
@michalvavrik michalvavrik force-pushed the feature/programmatic-oidc-startup branch from a6cbd2d to e85bc86 Compare December 30, 2024 00:22
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Dec 30, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit e85bc86.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Dec 30, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e85bc86.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin sberyozkin self-requested a review January 1, 2025 18:56
@sberyozkin sberyozkin merged commit 15ffade into quarkusio:main Jan 1, 2025
26 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 1, 2025
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jan 1, 2025
@michalvavrik michalvavrik deleted the feature/programmatic-oidc-startup branch January 1, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

Assignees
No one assigned
Labels
area/docstyle issues related for manual docstyle review area/documentation area/keycloak area/oidc kind/enhancement New feature or request release/noteworthy-feature
Projects
None yet
Milestone
3.18.0.CR1
Development

Successfully merging this pull request may close these issues.

Programmatic OIDC startup
2 participants
@michalvavrik @sberyozkin