Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce IsLocalDevelopment boolean supplier #45145

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

aloubyansky
Copy link
Member

IsLocalDevelopment should probably used now for all the Dev UI-related build steps instead of IsDevelopment.

It should also apply to any build step not relevant for a mutable-jar application launched in dev mode (remote-dev server)

Copy link

quarkus-bot bot commented Dec 16, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 7e19d99.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@aloubyansky
Copy link
Member Author

Phillip's input is relevant here but given he's on PTO and Dev UI is not currently supported for mutable-jar apps launched in dev mode, I'm gonna merge it in favor of making further progress on #45053

@aloubyansky
Copy link
Member Author

Dev UI is not currently supported for mutable-jar apps launched in dev mode

That is launched with java -jar quarku-run.jar and QUARKUS_LAUNCH_DEVMODE=true.

@aloubyansky aloubyansky merged commit 0396c33 into quarkusio:main Dec 17, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants