Update OIDC bearer doc with a section about response filters #45143
Conversation
quarkus-bot
bot
added
area/docstyle
| import io.quarkus.oidc.runtime.OidcUtils; | ||
|
|
||
| @ApplicationScoped | ||
| @Unremovable |
There was a problem hiding this comment.
Is @Unremovable always required? Wonder if beans with @OidcEndpoint can be considered @Unremovable by default
There was a problem hiding this comment.
@gastaldi Thanks, interesting idea, we can probably make an enhancement request to introspect it at build time. Though @OidcEndpont is optional, without it a filter applies to all endpoint responses (in case of response filters)
There was a problem hiding this comment.
Right, or maybe consider OidcResponseFilter implementations unremovable?
There was a problem hiding this comment.
Yeah, for all 3 types of filters (request, response, redirect)
docs/src/main/asciidoc/security-oidc-bearer-token-authentication.adoc
Outdated
Show resolved
Hide resolved
sberyozkin
force-pushed
the
oidc_bearer_response_filters
branch
from
4a00109 to
a781b4f
Compare
docs/src/main/asciidoc/security-oidc-code-flow-authentication.adoc
Outdated
Show resolved
Hide resolved
| if (contentType.equals("application/json") { | ||
| String tenantId = rc.requestProperties().get(OidcUtils.TENANT_ID_ATTRIBUTE); <3> | ||
| String metadata = rc.responseBody().toString(); <4> | ||
| LOG.debugf("Tenant %s OIDC metadata: %s", tenantId, metadata); |
There was a problem hiding this comment.
For a cleaner code, how about using io.quarkus.logging.Log instead?
There was a problem hiding this comment.
@gastaldi Sure, updated both docs, thanks
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
sberyozkin
force-pushed
the
oidc_bearer_response_filters
branch
from
a781b4f to
160392c
Compare
sberyozkin
force-pushed
the
oidc_bearer_response_filters
branch
from
160392c to
e72472f
Compare
Status for workflow
|
This PR adds a missing section about OIDC response filters to the OIDC bearer guide