Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break build cycle between OTel, logging and Flyway #45136

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Dec 16, 2024

@geoand
Copy link
Contributor Author

geoand commented Dec 16, 2024

The issue with this one is that I have no idea what problem @Consume(LoggingSetupBuildItem.class) solved.
It was introduced in 72a983f but I don't see an example of what prompted its inclusion.

Copy link

quarkus-bot bot commented Dec 16, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 327341c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand
Copy link
Contributor Author

geoand commented Dec 16, 2024

An alternative fix would be to check if the bean has been initialized and if not queue the records and it does become available to emit them all.
This solution however would require an API for checking whether a synthetic bean has been initialized. See this for more details.

@gsmet
Copy link
Member

gsmet commented Dec 16, 2024

Yeah I also had a quick look yesterday and this is similar to another issue we had a few weeks back.

I'm a bit worried about just dropping @stuartwdouglas 's fix. Also a bit worried in general as this cycle is something that could happen quite a lot.

@geoand
Copy link
Contributor Author

geoand commented Dec 16, 2024

I'm a bit worried about just dropping @stuartwdouglas 's fix

Me too, but I don't have a way of knowing what problem it was meant to fix

Also a bit worried in general as this cycle is something that could happen quite a lot.

I think this specific instance is pretty unique as creating LogHandlerBuildItem is not terribly common among extensions

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I suppose we will have reports soon enough if it's still needed.

@gsmet gsmet merged commit 190d689 into quarkusio:main Dec 17, 2024
25 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 17, 2024
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.5 Dec 17, 2024
@geoand geoand deleted the #45130-take2 branch December 17, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicting open telemetry and flyway dependencies
3 participants