Avoiding calculate conditional dependencies again for the same configuration, model and project

[cdsap]

Second Attempt to Mitigate Issue #44940

It is still unclear why the resolved configuration is triggered multiple times when resolving the conditional dependencies during configuration time with the compatible type. During the investigation, I observed that the first resolution is triggered in:

quarkus/devtools/gradle/gradle-model/src/main/java/io/quarkus/gradle/dependency/ConditionalDependenciesEnabler.java

Line 50 in fc237a6

collectConditionalDependencies(baseRuntimeConfig.getResolvedConfiguration().getResolvedArtifacts(), mode);

Subsequently, there are additional resolution in:

quarkus/devtools/gradle/gradle-model/src/main/java/io/quarkus/gradle/dependency/ConditionalDependenciesEnabler.java

Line 122 in fc237a6

Set<ResolvedArtifact> resolvedArtifacts = conditionalDeps.getResolvedConfiguration().getResolvedArtifacts();

This behavior triggers the same resolution an arbitrary number of times.

This PR avoids triggering a new resolution of the conditional dependencies when the mode, project, and configuration have already been resolved. While this workaround reduces configuration time, the underlying cause of the multiple resolutions in the tests remains to be understood. The investigation continues but with this PR we reduce the current configuration time for large projects:

3.16.4

• Configuration time first build in fresh daemon (dependencies downloaded): 16s https://ge.solutions-team.gradle.com/s/ejpasnot2emzg/performance/configuration#summary-total
• Configuration time second build dependencies downloaded): 13s https://ge.solutions-team.gradle.com/s/ehp2d6lq2gxrs/performance/configuration#summary-total

This PR

• Configuration time first build in fresh daemon (dependencies downloaded): 9s https://ge.solutions-team.gradle.com/s/l425qx4xebsfs/performance/configuration#summary-total
• Configuration time second build dependencies downloaded): 6s https://ge.solutions-team.gradle.com/s/l6uqgfq26pe4y/performance/configuration#summary-total

[gsmet]

@aloubyansky wondering if the findings here could lead to an investigation on our side?

[aloubyansky]

Thanks @cdsap !

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c57799c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.