Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority of REST Client Config changed to Quarkus FQN, config key, simple name #45044

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Dec 10, 2024

This fixes a couple of problems:

The priority checks for properties were FQN, SimpleName, and config key. In cases where the Simple Name is the same (but the classes are in different packages), it would mess up the configuration. We should consider removing Simple Name as a possible combination. Here is also a related discussion: #44067 (comment)

Relocates for shared config keys used a single Map which override the relocate name when the config key is shared. It now uses a Map with a List to keep track of all possible relocations.

This comment has been minimized.

Copy link

github-actions bot commented Dec 10, 2024

🎊 PR Preview 98a9361 has been successfully built and deployed to https://quarkus-pr-main-45044-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Dec 10, 2024

I pushed the formatting fix.

Copy link

quarkus-bot bot commented Dec 10, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 79e2beb.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@radcortez
Copy link
Member Author

Thanks!

Copy link

quarkus-bot bot commented Dec 11, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 79e2beb.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit cf5db42 into quarkusio:main Dec 11, 2024
34 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 11, 2024
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Dec 11, 2024
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.5 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST Client using configKey resolves wrong config REST Client not sending headers from shared configKey
3 participants