Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly create REST Client template path when @Url is used #45010

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Dec 9, 2024

Copy link

quarkus-bot bot commented Dec 9, 2024

/cc @ebullient (micrometer)

@brunobat
Copy link
Contributor Author

brunobat commented Dec 9, 2024

@geoand, got this reproduced but I miss to understand why the ClientObservabilityHandler was not set when the withNewUri is called on line 1017.

@geoand geoand changed the title Fix missing target template tag when using @Url Properly create REST Client template path when @Url is used Dec 10, 2024
@geoand
Copy link
Contributor

geoand commented Dec 10, 2024

PR updated

@geoand geoand marked this pull request as ready for review December 10, 2024 07:00
@geoand geoand requested a review from cescoffier December 10, 2024 07:04
@cescoffier
Copy link
Member

Should it be backported to 3.15? When was this introduced?

@geoand
Copy link
Contributor

geoand commented Dec 10, 2024

It was actually introduced in 3.16

@geoand
Copy link
Contributor

geoand commented Dec 10, 2024

We are getting a bunch of docker related errors, so I'm going to have try CI again later

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 10, 2024

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Dec 10, 2024

Not sure what the deal with the Redis test on Windows is

@brunobat
Copy link
Contributor Author

brunobat commented Dec 10, 2024

Not sure what the deal with the Redis test on Windows is

Looks like it complains it cannot find a Docker environment:
https://github.com/quarkusio/quarkus/actions/runs/12254593642/job/34198505954#step:17:18758

@geoand
Copy link
Contributor

geoand commented Dec 10, 2024

Yeah, the question is why. We shouldn't be running docker related tests on Windows anyway

Copy link

quarkus-bot bot commented Dec 11, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 37c50ee.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit 00e07bd into quarkusio:main Dec 11, 2024
32 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 11, 2024
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Dec 11, 2024
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.5 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants