Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed Guillaume started preparing for 3.17.4, so here is a PR with 2 minor OIDC updates, following some recent demo experiments:
quarkus-oidc
fails to exchange the code for tokens, it will pass theauthorization endpoint URI
, as opposed to the correcttoken endpoint URI
to the method which logs this URI in case of the error, I've been confused by it for a while, since it is only a user who is facing the authorization endpoint challenge,quarkus-oidc
never calls it directly, it only calls the token endpointquarkus-oidc
, is not visible to the code which hasOidcConfigurationMetadata
injected. It is not a big problem, https://quarkus.io/guides/security-openid-connect-client-registration does not require it, and it is expected thatquarkus-oidc-client-registration
can function completely independently, without even expectingquarkus-oidc
loaded. Butquarkus-oidc-client-registration
needs theregistration URI
to initialize itself, so ifquarkus-oidc
is loaded, it may as well pick up the already discoveredregistration URI