Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor OIDC updates #44986

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Minor OIDC updates #44986

merged 1 commit into from
Dec 8, 2024

Conversation

sberyozkin
Copy link
Member

I've noticed Guillaume started preparing for 3.17.4, so here is a PR with 2 minor OIDC updates, following some recent demo experiments:

  • When quarkus-oidc fails to exchange the code for tokens, it will pass the authorization endpoint URI, as opposed to the correct token endpoint URI to the method which logs this URI in case of the error, I've been confused by it for a while, since it is only a user who is facing the authorization endpoint challenge, quarkus-oidc never calls it directly, it only calls the token endpoint
  • OIDC Client registration URI, even though it may have been discovered by quarkus-oidc, is not visible to the code which has OidcConfigurationMetadata injected. It is not a big problem, https://quarkus.io/guides/security-openid-connect-client-registration does not require it, and it is expected that quarkus-oidc-client-registration can function completely independently, without even expecting quarkus-oidc loaded. But quarkus-oidc-client-registration needs the registration URI to initialize itself, so if quarkus-oidc is loaded, it may as well pick up the already discovered registration URI

Copy link

github-actions bot commented Dec 7, 2024

🎊 PR Preview 47567e7 has been successfully built and deployed to https://quarkus-pr-main-44986-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link

quarkus-bot bot commented Dec 7, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 298daf3.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Dec 7, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 298daf3.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin sberyozkin merged commit e7b3e25 into quarkusio:main Dec 8, 2024
25 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 8, 2024
@sberyozkin sberyozkin deleted the minor_oidc_fixes branch December 8, 2024 12:16
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.4 Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants