Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring the deploying-to-heroku guide up to date #44978

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

starksm64
Copy link
Contributor

Fixes #44857

Copy link

github-actions bot commented Dec 7, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

starksm64 and others added 2 commits December 16, 2024 13:18
It's a lot more natural to create a simple application using our tooling
rather than doing all sorts of manipulation to extract the code from the
quickstarts repo.
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@starksm64 I did some simple changes to avoid having to extract the code from the quickstarts. Bootstrapping a new app is a lot more natural and easier, and probably how you should do things in real life.

I also used our tab-based infrastructure to present alternatives for Quarkus CLI and Maven.

Copy link

quarkus-bot bot commented Dec 16, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 9da5a09.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@cescoffier cescoffier merged commit 35ccb2e into quarkusio:main Jan 6, 2025
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deploying-to-heroku is out of date
3 participants