Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Cache - Allow usage of cache name when prefix is defined #44856

Conversation

thibaultmeyer
Copy link
Contributor

Resolves: #44693

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add a simple test?

Tests are located in the deployment module (because it needs the build time processing to run). A simple test verifying that the "cache-name" is taking into account would be great.

It would be great to add a line about this improvement in https://quarkus.io/guides/cache-redis-reference.

This comment has been minimized.

Copy link

github-actions bot commented Dec 1, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@thibaultmeyer thibaultmeyer force-pushed the feature/44693-cache_redis_allow_usage_cachename branch from 27e91bc to 204efde Compare December 1, 2024 18:05

This comment has been minimized.

@thibaultmeyer thibaultmeyer force-pushed the feature/44693-cache_redis_allow_usage_cachename branch from 204efde to 4147c6d Compare December 1, 2024 18:28
Copy link

quarkus-bot bot commented Dec 1, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4147c6d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

Copy link

quarkus-bot bot commented Dec 1, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 4147c6d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@thibaultmeyer
Copy link
Contributor Author

thibaultmeyer commented Dec 1, 2024

@cescoffier

done, are modifications OK ?

@cescoffier cescoffier merged commit 2c31260 into quarkusio:main Dec 2, 2024
23 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 2, 2024
@cescoffier
Copy link
Member

Thanks!

@thibaultmeyer thibaultmeyer deleted the feature/44693-cache_redis_allow_usage_cachename branch December 4, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis cache "prefix" option erase the cache name / Prefix option is not a real prefix
2 participants