Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.17] 3.17.3 backports 1 #44849

Merged
merged 11 commits into from
Dec 1, 2024
Merged

[3.17] 3.17.3 backports 1 #44849

merged 11 commits into from
Dec 1, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Nov 30, 2024

Please don't merge, I will merge it myself.

radcortez and others added 11 commits November 30, 2024 18:44
@radcortez @gsmet
Split creation of the Set to match unknown properties to avoid Method…
3956d25 
…TooLargeException

(cherry picked from commit 1db73a7)
@gastaldi @gsmet
Add OpenPGP's Bouncycastle library to application's BOM
2392314 
Other Bouncycastle libraries are already managed in the application's BOM

(cherry picked from commit f4dd1b4)
@gsmet
Drop mentions of quarkus.ssl.native=false in Hibernate Search guides
5a834cf 
I don't think it's a good idea to promote disabling SSL globally and it
has been causing issues for users as evidenced in:
https://quarkusio.zulipchat.com/#narrow/channel/187030-users/topic/Hibernate.20Search.20-.20Failed.20to.20start.20quarkus

Note that the issue was due to a bug in another area but still.

(cherry picked from commit 527370c)
@zhfeng @gsmet
Fix typo with classes() method
a32ec7e 
(cherry picked from commit 04bcfd2)
@geoand @gsmet
Default to old console if user has not set it
35406d4 
This is done because the new JLine console
which is the default from JDK 23 (maybe even 22?)
causes a large regression in startup time due to
it loading a very large number of classes.

If users really want to use the new console,
they have to start the application with
`-Djdk.console=jdk.internal.le`

Fixes: quarkusio#44471
Fixes: quarkusio#44653
(cherry picked from commit 88a0dce)
@radcortez @gsmet
Fix NPE caused by PropertyName map with Mappings names
bb199e6 
(cherry picked from commit 837a603)
@dependabot @gsmet
Bump com.fasterxml.jackson:jackson-bom from 2.18.1 to 2.18.2
9761e49 
Bumps [com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.18.1 to 2.18.2.
- [Commits](FasterXML/jackson-bom@jackson-bom-2.18.1...jackson-bom-2.18.2)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson:jackson-bom
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
(cherry picked from commit 101d353)
@gsmet
Apply TrimmedStringConverter to proxyAddress configuration property
a3b4042 
(cherry picked from commit 2654019)
@mkouba @gsmet
Qute: fix perf optimization in ReflectionValueResolver
1a5fe71 
- fixes quarkusio#44797

(cherry picked from commit 06f4006)
@gsmet
Fix off-by-one error in exception decoration code
e4d67fc 
This was failing only in dev mode when using printf-style logging.

Fixes smallrye/smallrye-graphql#2230

(cherry picked from commit 64f0108)
@radcortez @gsmet
Update SmallRye Config to 3.10.2
f10d3a4 
(cherry picked from commit 8ed00f4)
@gsmet gsmet added the area/infra internal and infrastructure related issues label Nov 30, 2024
@gsmet gsmet self-assigned this Nov 30, 2024
@quarkus-bot quarkus-bot bot changed the title 3.17.3 backports 1 [3.17] 3.17.3 backports 1 Nov 30, 2024
@quarkus-bot quarkus-bot bot added area/config area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle area/platform Issues related to definition and interaction with Quarkus Platform area/rest area/rest-client area/resteasy-classic labels Nov 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 30, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit f10d3a4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 30, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f10d3a4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/grpc-hibernate

✖ com.example.grpc.hibernate.VertxBlockingRawTest.shouldAdd - History

  • Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

⚙️ Maven Tests - JDK 17 Windows

📦 integration-tests/maven

✖ io.quarkus.maven.it.TestMojoIT.testThatTheTestsAreReRunMultiModule - History

  • Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils.waitForNextCompletion(TestModeContinuousTestingMavenTestUtils.java:50)
	at io.quarkus.maven.it.LaunchMojoTestBase.testThatTheTestsAreReRunMultiModule(LaunchMojoTestBase.java:56)

✖ io.quarkus.maven.it.TestMojoIT.testThatTheTestsAreReRunMultiModule - History

  • Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils.waitForNextCompletion(TestModeContinuousTestingMavenTestUtils.java:50)
	at io.quarkus.maven.it.LaunchMojoTestBase.testThatTheTestsAreReRunMultiModule(LaunchMojoTestBase.java:56)

⚙️ Native Tests - HTTP

📦 integration-tests/rest-client-reactive

✖ io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History

  • expected: <1> but was: <2> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:806)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@gsmet gsmet merged commit 4ac00d5 into quarkusio:3.17 Dec 1, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gsmet gsmet

Labels
area/config area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle area/infra internal and infrastructure related issues area/platform Issues related to definition and interaction with Quarkus Platform area/rest area/rest-client area/resteasy-classic triage/flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gsmet @radcortez @gastaldi @zhfeng @geoand @mkouba