Update Kotlin to version 2.1.0 #44809

andreas-eberle · 2024-11-28T14:33:22Z

This PR updates Kotlin to the newly released version 2.1.0

quarkus-bot · 2024-11-28T14:33:26Z

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

_{This message is automatically generated by a bot.}

gsmet · 2024-11-29T14:30:43Z

Thanks for taking care of this!

geoand · 2024-12-03T11:35:30Z

Can you please rebase onto main?

andreas-eberle · 2024-12-03T12:59:56Z

Thanks for the reminder. I forgot I didn't push my last commit and undraft this. It should be updated and hopefully the CI passes now.

geoand · 2024-12-03T13:02:44Z

Thanks!

github-actions · 2024-12-03T13:31:08Z

🎊 PR Preview 0ac0e12 has been successfully built and deployed to https://quarkus-pr-main-44809-preview.surge.sh/version/main/guides/

Images of blog posts older than 3 months are not available.
Newsletters older than 3 months are not available.

geoand · 2024-12-03T13:35:23Z

CI didn't really run on this which is really weird

gsmet

Thanks for this effort, greatly appreciated.

I have a question though and I would like to get it sorted out before we merge. See inline.

gsmet · 2024-12-03T17:27:50Z

...dard/src/main/kotlin/io/quarkus/it/resteasy/reactive/kotlin/CountryNamePayloadTransformer.kt

@@ -12,6 +12,6 @@ class CountryNamePayloadTransformer {
    @Outgoing("countries-t1-out")
    suspend fun transform(country: Country): Country {
        delay(100)
-        return Country(country.name.toUpperCase(), country.capital)
+        return Country(country.name.lowercase(), country.capital)


Is it expected that you changed toUpperCase() to lowercase()? It might make sense but it looks odd to me?

Yes, this is actually required. The toLowerCase method has been deprecated with a warning for a while but now they removed it or changed it to an error (I don't remember exactly any more, but the project didn't compile any longer). So this is a needed fix and lowercase() is the intended replacement.

I would expect uppercase() to be the replacement for toUpperCase() :).

geoand · 2024-12-04T08:37:30Z

Seems like quarkus-integration-test-kotlin is failing because of:

2024-12-04T07:18:19.3974147Z Caused by: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
2024-12-04T07:18:19.3977020Z 	[error]: Build step io.quarkus.smallrye.graphql.deployment.SmallRyeGraphQLProcessor#buildExecutionService threw an exception: java.lang.IllegalArgumentException: Provided Metadata instance has version 2.1.0, while maximum supported version is 2.0.0. To support newer versions, update the kotlinx-metadata-jvm library.
2024-12-04T07:18:19.3979808Z 	at kotlinx.metadata.jvm.KotlinClassMetadata$Companion.throwIfNotCompatible$kotlinx_metadata_jvm(KotlinClassMetadata.kt:609)
2024-12-04T07:18:19.3981342Z 	at kotlinx.metadata.jvm.KotlinClassMetadata$Companion.checkMetadataVersionForRead(KotlinClassMetadata.kt:600)
2024-12-04T07:18:19.3982604Z 	at kotlinx.metadata.jvm.KotlinClassMetadata$Companion.read(KotlinClassMetadata.kt:579)
2024-12-04T07:18:19.3983607Z 	at kotlinx.metadata.jvm.KotlinClassMetadata.read(KotlinClassMetadata.kt)
2024-12-04T07:18:19.3984939Z 	at io.smallrye.graphql.schema.creator.OperationCreator.toKotlinClassMetadata(OperationCreator.java:264)
2024-12-04T07:18:19.3986391Z 	at io.smallrye.graphql.schema.creator.OperationCreator.checkWrappedTypeKotlinNullability(OperationCreator.java:126)
2024-12-04T07:18:19.3987866Z 	at io.smallrye.graphql.schema.creator.OperationCreator.createOperation(OperationCreator.java:112)
2024-12-04T07:18:19.3989154Z 	at io.smallrye.graphql.schema.SchemaBuilder.addOperations(SchemaBuilder.java:448)
2024-12-04T07:18:19.3990221Z 	at io.smallrye.graphql.schema.SchemaBuilder.lambda$generateSchema$2(SchemaBuilder.java:159)
2024-12-04T07:18:19.3991175Z 	at java.base/java.util.Optional.ifPresentOrElse(Optional.java:198)
2024-12-04T07:18:19.3992078Z 	at io.smallrye.graphql.schema.SchemaBuilder.generateSchema(SchemaBuilder.java:157)
2024-12-04T07:18:19.3993044Z 	at io.smallrye.graphql.schema.SchemaBuilder.build(SchemaBuilder.java:109)
2024-12-04T07:18:19.3994359Z 	at io.quarkus.smallrye.graphql.deployment.SmallRyeGraphQLProcessor.buildExecutionService(SmallRyeGraphQLProcessor.java:363)
2024-12-04T07:18:19.3995779Z 	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
2024-12-04T07:18:19.3996623Z 	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
2024-12-04T07:18:19.3997400Z 	at io.quarkus.builder.BuildContext.run(BuildContext.java:256)
2024-12-04T07:18:19.3998160Z 	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
2024-12-04T07:18:19.3999290Z 	at org.jboss.threads.EnhancedQueueExecutor$Task.doRunWith(EnhancedQueueExecutor.java:2675)
2024-12-04T07:18:19.4000364Z 	at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2654)
2024-12-04T07:18:19.4001695Z 	at org.jboss.threads.EnhancedQueueExecutor.runThreadBody(EnhancedQueueExecutor.java:1627)
2024-12-04T07:18:19.4002858Z 	at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1594)
2024-12-04T07:18:19.4003716Z 	at java.base/java.lang.Thread.run(Thread.java:840)
2024-12-04T07:18:19.4004321Z 	at org.jboss.threads.JBossThread.run(JBossThread.java:499)

cc @jmartisk

jmartisk · 2024-12-04T09:30:12Z

Right, I'll try to upgrade kotlinx.metadata.jvm in smallrye-graphql, so this will have to wait until a smallrye-graphql upgrade is merged..

geoand · 2024-12-04T09:30:55Z

Thanks!

andreas-eberle · 2024-12-04T10:40:40Z

Thanks! Sorry I wasn't able too look for the errors in time. I'm unfortunately a bit swamped right now.

gsmet · 2024-12-05T15:42:00Z

Waiting for smallrye/smallrye-graphql#2234 to land in Quarkus.

gsmet · 2024-12-20T08:37:35Z

@andreas-eberle probably a good idea to include these two changes in this PR:

A new version of SmallRye GraphQL was released so hopefully we will be able to make progress on this one soon!

andreas-eberle · 2024-12-20T09:19:28Z

@gsmet: I've quickly updated the coroutines library and also the smallrye graphql dependency. Let's see if that already fixes the issues.

gsmet · 2024-12-20T09:26:20Z

Yeah so the GraphQL one won't work as the update breaks things. We will have to wait for the SmallRye GraphQL team to push a proper update.

andreas-eberle · 2024-12-20T09:29:09Z

Thanks for the info @gsmet. Then I'll rebase the PR as soon as the graphql update is properly integrated.

jmartisk · 2024-12-20T10:54:26Z

@andreas-eberle I've submitted #45228 that also incorporates your commit (and the coroutines upgrades mentioned earlier), I think we need to apply both upgrades at the same time. Please check it

andreas-eberle · 2024-12-20T10:58:03Z

Thanks @jmartisk. Looks good for me from the kotlin update side. Let's see what CI says about your PR. I will close this one.

geoand · 2024-12-20T10:58:04Z

Closing in favor of #45228

quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Nov 28, 2024

andreas-eberle force-pushed the feature/kotlin-2.1.0 branch from b458ffd to 55f2f23 Compare November 29, 2024 12:51

andreas-eberle force-pushed the feature/kotlin-2.1.0 branch 2 times, most recently from c578c94 to 6404e78 Compare December 3, 2024 12:58

andreas-eberle marked this pull request as ready for review December 3, 2024 12:59

geoand approved these changes Dec 3, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

gsmet requested changes Dec 3, 2024

View reviewed changes

andreas-eberle force-pushed the feature/kotlin-2.1.0 branch from 6404e78 to f629bf6 Compare December 3, 2024 20:59

This comment has been minimized.

Sign in to view

jmartisk mentioned this pull request Dec 4, 2024

Update kotlinx-metadata-jvm to 0.9.0 smallrye/smallrye-graphql#2234

Merged

This comment has been minimized.

Sign in to view

quarkus-bot bot added the triage/flaky-test label Dec 4, 2024

gsmet marked this pull request as draft December 5, 2024 15:42

andreas-eberle force-pushed the feature/kotlin-2.1.0 branch from f629bf6 to 9e64b27 Compare December 10, 2024 19:33

Update Kotlin to version 2.1.0 & Kotlin Coroutines to version 1.10.0

d36a7f3

andreas-eberle force-pushed the feature/kotlin-2.1.0 branch from 9e64b27 to d36a7f3 Compare December 20, 2024 09:15

Update Smallrye GraphQL Version to 2.12.0

dc34c6d

jmartisk mentioned this pull request Dec 20, 2024

SmallRye GraphQL 2.12.0 #45228

Merged

andreas-eberle closed this Dec 20, 2024

quarkus-bot bot added the triage/invalid This doesn't seem right label Dec 20, 2024

andreas-eberle deleted the feature/kotlin-2.1.0 branch December 20, 2024 10:58

andreas-eberle mentioned this pull request Jan 9, 2025

Update Kotlin to version 2.1.0 #45470

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Kotlin to version 2.1.0 #44809

Update Kotlin to version 2.1.0 #44809

andreas-eberle commented Nov 28, 2024 •

edited

Loading

quarkus-bot bot commented Nov 28, 2024

gsmet commented Nov 29, 2024

geoand commented Dec 3, 2024

andreas-eberle commented Dec 3, 2024

geoand commented Dec 3, 2024

This comment has been minimized.

github-actions bot commented Dec 3, 2024 •

edited

Loading

This comment has been minimized.

geoand commented Dec 3, 2024

gsmet left a comment

gsmet Dec 3, 2024

andreas-eberle Dec 3, 2024

gsmet Dec 4, 2024

This comment has been minimized.

geoand commented Dec 4, 2024 •

edited

Loading

jmartisk commented Dec 4, 2024

geoand commented Dec 4, 2024

andreas-eberle commented Dec 4, 2024

This comment has been minimized.

gsmet commented Dec 5, 2024

gsmet commented Dec 20, 2024

andreas-eberle commented Dec 20, 2024

gsmet commented Dec 20, 2024

andreas-eberle commented Dec 20, 2024

jmartisk commented Dec 20, 2024 •

edited

Loading

andreas-eberle commented Dec 20, 2024

geoand commented Dec 20, 2024

Update Kotlin to version 2.1.0 #44809

Update Kotlin to version 2.1.0 #44809

Conversation

andreas-eberle commented Nov 28, 2024 • edited Loading

quarkus-bot bot commented Nov 28, 2024

gsmet commented Nov 29, 2024

geoand commented Dec 3, 2024

andreas-eberle commented Dec 3, 2024

geoand commented Dec 3, 2024

This comment has been minimized.

github-actions bot commented Dec 3, 2024 • edited Loading

This comment has been minimized.

geoand commented Dec 3, 2024

gsmet left a comment

Choose a reason for hiding this comment

gsmet Dec 3, 2024

Choose a reason for hiding this comment

andreas-eberle Dec 3, 2024

Choose a reason for hiding this comment

gsmet Dec 4, 2024

Choose a reason for hiding this comment

This comment has been minimized.

geoand commented Dec 4, 2024 • edited Loading

jmartisk commented Dec 4, 2024

geoand commented Dec 4, 2024

andreas-eberle commented Dec 4, 2024

This comment has been minimized.

gsmet commented Dec 5, 2024

gsmet commented Dec 20, 2024

andreas-eberle commented Dec 20, 2024

gsmet commented Dec 20, 2024

andreas-eberle commented Dec 20, 2024

jmartisk commented Dec 20, 2024 • edited Loading

andreas-eberle commented Dec 20, 2024

geoand commented Dec 20, 2024

andreas-eberle commented Nov 28, 2024 •

edited

Loading

github-actions bot commented Dec 3, 2024 •

edited

Loading

geoand commented Dec 4, 2024 •

edited

Loading

jmartisk commented Dec 20, 2024 •

edited

Loading