Default to old console if user has not set it

[geoand]

This is done because the new JLine console
which is the default from JDK 23 (maybe even 22?)
causes a large regression in startup time due to
it loading a very large number of classes.

If users really want to use the new console,
they have to start the application with

-Djdk.console=jdk.internal.le

• Fixes: JDK 23 new console is causing a serious regression in startup #44471
• Fixes: Dev console "crashes" with Java 23 #44653

Note on testing

I tried to create a proper test for this but it's not easy because we don't have an attached console to check against (if we did, we could open up Java IO using: --add-opens=java.base/java.io=ALL-UNNAMED and do something like:

private String determineConsoleName() {
        Console console = System.console();
        if (console == null) {
            return "null";
        }
        // in JDK 21+, the actual console is hidden behind in a delegate
        if ("java.io.ProxyingConsole".equals(console.getClass().getName())) {
            try {
                Class<?> proxyingClass = Thread.currentThread().getContextClassLoader().loadClass("java.io.ProxyingConsole");
                Field delegateField = proxyingClass.getDeclaredField("delegate");
                delegateField.setAccessible(true);
                Object jdkConsole = delegateField.get(console);
                return jdkConsole.getClass().getName();
            } catch (Exception e) {
                throw new RuntimeException(e);
            }
        }
        return console.getClass().getName();
    }

[gsmet]

Is it something that we should consider pushing to 3.15 at some point? Given it's a LTS, I'm pretty sure Java 23 or 24 will be used with this version.

[geoand]

Yeah, we probably should

…

On Thu, Nov 28, 2024, 12:58 Guillaume Smet ***@***.***> wrote: Is it something that we should consider pushing to 3.15 at some point? Given it's a LTS, I'm pretty sure Java 23 or 24 will be used with this version. — Reply to this email directly, view it on GitHub <#44796 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBMDP7MJWSXGA6LPTLXITT2C3ZOTAVCNFSM6AAAAABSUZC6BGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBVHAZTOMRQHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 88a0dce.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging/deployment

✖ io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

• Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError

java.lang.AssertionError: 

Expecting actual:
  ["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

---

⚙️ Native Tests - HTTP

📦 integration-tests/rest-client-reactive

✖ io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History

• expected: <1> but was: <2> - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:806)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)