-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid reifing Agroal configuration too early #44688
Conversation
In OracleAgroalConnectionConfigurer, we are reifing the Agroal config and we shouldn't do it at this stage. We need to check the properties directly and thus we add them to AgroalConnectionConfigurer. I kept the old method for now but it will be removed at some point in the future. Fixes quarkusio#44687
Status for workflow
|
🎊 PR Preview a3ce841 has been successfully built and deployed to https://quarkus-pr-main-44688-preview.surge.sh/version/main/guides/
|
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Though I must admit I wonder why this object cannot be accessed twice. Shouldn't the recorder that produces it, or even Quarkus' bytecode recorder system itself, cache the produced instance?
Yeah so the In this case, we were building the config so that we would have a getter to get the properties as the builder doesn't have getters (which makes sense). So really, we were bending the API. |
In OracleAgroalConnectionConfigurer, we are reifing the Agroal config and we shouldn't do it at this stage.
We need to check the properties directly and thus we add them to AgroalConnectionConfigurer. I kept the old method for now but it will be removed at some point in the future.
Fixes #44687