Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reifing Agroal configuration too early #44688

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Nov 25, 2024

In OracleAgroalConnectionConfigurer, we are reifing the Agroal config and we shouldn't do it at this stage.
We need to check the properties directly and thus we add them to AgroalConnectionConfigurer. I kept the old method for now but it will be removed at some point in the future.

Fixes #44687

In OracleAgroalConnectionConfigurer, we are reifing the Agroal config
and we shouldn't do it at this stage.
We need to check the properties directly and thus we add them to
AgroalConnectionConfigurer. I kept the old method for now but it will be
removed at some point in the future.

Fixes quarkusio#44687
@quarkus-bot quarkus-bot bot added area/agroal area/jdbc Issues related to the JDBC extensions labels Nov 25, 2024
@gsmet gsmet requested a review from yrodiere November 25, 2024 15:33
Copy link

quarkus-bot bot commented Nov 25, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 4367b5f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

🎊 PR Preview a3ce841 has been successfully built and deployed to https://quarkus-pr-main-44688-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link

quarkus-bot bot commented Nov 25, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4367b5f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Though I must admit I wonder why this object cannot be accessed twice. Shouldn't the recorder that produces it, or even Quarkus' bytecode recorder system itself, cache the produced instance?

@gsmet
Copy link
Member Author

gsmet commented Nov 26, 2024

Yeah so the FooConfigSupplier of Agroal are basically builders that you can build only once.

In this case, we were building the config so that we would have a getter to get the properties as the builder doesn't have getters (which makes sense).

So really, we were bending the API.

@gastaldi gastaldi merged commit 2a5a167 into quarkusio:main Nov 26, 2024
45 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agroal area/jdbc Issues related to the JDBC extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OracleAgroalConnectionConfigurer is initializing AgroalConnectionPoolConfigurationSupplier too early
4 participants