-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify name of generated exception mappers #44418
Conversation
geoand
commented
Nov 11, 2024
•
edited
Loading
edited
- Closes: Rest: shorten the names of the generated classes #43786
Status for workflow
|
return targetMethod.declaringClass().name() + "$GeneratedExceptionHandlerFor$" | ||
+ handledExceptionType.name().withoutPackagePrefix() | ||
+ "$OfMethod$" + targetMethod.name(); | ||
return targetMethod.declaringClass().name() + "$ExceptionMapper$" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not replace $ExceptionMapper$
with the method name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find that looking at this name I know for sure that is a generated exception mapper without having to look into the code itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed you know what it is, but you don't know where it's defined, so you can't find it back easily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whereas if you can find it back, then it's pretty obvious what it is once you look at it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I say let's roll with the change as is and we can always come back if we find it confusing in practice