Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove com.google.code.findbugs:jsr305 from gRPC #44328

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

mabartos
Copy link
Contributor

@mabartos mabartos commented Nov 5, 2024

Closes #44325

We will see how CI will behave.

Is there any problem with removing the dep from BOM? I don't think so, but not sure about your policy around this. The dep needs to be part of the BOM - at least mongodb-client extension uses it.

Unfortunately, grpc/grpc-java still provides the dependency, so we are not able to remove these exclusions.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/grpc gRPC area/testing labels Nov 5, 2024
@mabartos mabartos marked this pull request as ready for review November 6, 2024 09:41

This comment has been minimized.

This comment has been minimized.

@cescoffier
Copy link
Member

The mongo compilation failure is unexpected - can you have a look?

@mabartos
Copy link
Contributor Author

mabartos commented Nov 7, 2024

@cescoffier Yes, I'll look.

@gsmet
Copy link
Member

gsmet commented Nov 7, 2024

@mabartos you can drop the @Nullable annotation from MongoTracingCommandListener. But please make sure this thing compiles before pushing as we might have other funkiness.

Running ./mvnw -T0.8C -Dquickly should be enough to verify things are not too bad.

@gsmet
Copy link
Member

gsmet commented Nov 12, 2024

I think I handled the issue, let's see what CI says.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 12, 2024
Copy link

quarkus-bot bot commented Nov 12, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 18eb86d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

🎊 PR Preview bbe15e8 has been successfully built and deployed to https://quarkus-pr-main-44328-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Copy link

quarkus-bot bot commented Nov 12, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 18eb86d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Native Tests - HTTP

📦 integration-tests/rest-client-reactive

io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History

  • expected: <1> but was: <2> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:805)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@mabartos
Copy link
Contributor Author

@gsmet Thanks for managing it! Didn't have time to look at it closer

@gsmet
Copy link
Member

gsmet commented Nov 12, 2024

No worries, it looked like an easy win for 3.17.

@gsmet gsmet merged commit 626658c into quarkusio:main Nov 12, 2024
38 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Nov 12, 2024
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/grpc gRPC area/mongodb area/testing kind/enhancement New feature or request triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove com.google.code.findbugs:jsr305 from gRPC
3 participants