-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove com.google.code.findbugs:jsr305 from gRPC #44328
Conversation
92f5071
to
d2cf9e3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The mongo compilation failure is unexpected - can you have a look? |
@cescoffier Yes, I'll look. |
@mabartos you can drop the Running |
Closes quarkusio#44325 Signed-off-by: Martin Bartoš <[email protected]>
d2cf9e3
to
18eb86d
Compare
I think I handled the issue, let's see what CI says. |
Status for workflow
|
🎊 PR Preview bbe15e8 has been successfully built and deployed to https://quarkus-pr-main-44328-preview.surge.sh/version/main/guides/
|
Status for workflow
|
@gsmet Thanks for managing it! Didn't have time to look at it closer |
No worries, it looked like an easy win for 3.17. |
Closes #44325
We will see how CI will behave.
Is there any problem with removing the dep from BOM? I don't think so, but not sure about your policy around this.The dep needs to be part of the BOM - at leastmongodb-client
extension uses it.Unfortunately, grpc/grpc-java still provides the dependency, so we are not able to remove these exclusions.