Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details about how to save state across live reloads #44287

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Nov 4, 2024

This PR adds details on writing-extension.adoc, about how to persist context across live reloads.

Fixes #44288

Copy link

quarkus-bot bot commented Nov 4, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@mcruzdev mcruzdev marked this pull request as ready for review November 4, 2024 12:44
@mcruzdev mcruzdev changed the title Add documentation about how-to save state across live reloads Add details about how to save state across live reloads Nov 4, 2024
@mcruzdev mcruzdev force-pushed the livereload-docs branch 2 times, most recently from 7bdd9da to 293afab Compare November 4, 2024 12:52
Copy link

quarkus-bot bot commented Nov 4, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit cbceabd.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Initial JDK 17 Build Build Failures Logs Raw logs 🔍

You can consult the Develocity build scans.

Failures

⚙️ Initial JDK 17 Build #

- Failing: extensions/smallrye-jwt/deployment 
! Skipped: docs integration-tests/management-interface-auth integration-tests/smallrye-jwt-oidc-webapp and 2 more

📦 extensions/smallrye-jwt/deployment

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project quarkus-smallrye-jwt-deployment: Compilation failure

Copy link

github-actions bot commented Nov 4, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mcruzdev, added minor suggestions

@sberyozkin
Copy link
Member

@mcruzdev Looks like you opened this PR on top of the existing branch for #44272, please open it in a new branch opened on top of main

@mcruzdev
Copy link
Contributor Author

mcruzdev commented Nov 4, 2024

@mcruzdev Looks like you opened this PR on top of the existing branch for #44272, please open it in a new branch opened on top of main

Yes, I made a mistake. I fixed it :)

This comment has been minimized.

@mcruzdev mcruzdev requested a review from sberyozkin November 4, 2024 20:28
Copy link

quarkus-bot bot commented Nov 4, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 8197835.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand merged commit 6e39316 into quarkusio:main Nov 5, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.17 - main milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation about how to store context across live reloads
3 participants