update postgres to newer version to fix fail to start on M2 laptops #44151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
quarkus-bot
bot
added
the
area/dependencies
|
@melloware This also partially fixes #42149 |
Yeah, pretty sure the upgrade was blocked because Flyway didn't work after the upgrade. |
|
And flyway failing was more than need to use flyway-database-postgresql when using Postgres ? |
|
Yes it looks like an issue where Flyway needed to change some code to be PG 16 compliant. |
|
@maxandersen open bug here: flyway/flyway#3743 |
|
I've run And got the following warning, but the app started ok: I'm using RHBQ 3.8.6.redhat-00005 though |
That additional dependency is already added automatically: #41862 We might need to update it, though, if the compatibility problem with Postgres 16 was fixed upstream. Anyway, tests are already failing in this PR, maybe let's wait for the report and the exact failure before we discuss solutions? |
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | JVM Tests - JDK 17 | Build |
Failures | Logs | Raw logs | 🔍 |
| ✖ | JVM Tests - JDK 21 | Build |
Failures | Logs | Raw logs | 🔍 |
| ✖ | Native Tests - Data3 | Build |
Failures | Logs | Raw logs | 🔍 |
Full information is available in the Build summary check run.
You can consult the Develocity build scans.
Failures
⚙️ JVM Tests - JDK 17 #
- Failing: integration-tests/flyway
📦 integration-tests/flyway
✖ io.quarkus.it.flyway.FlywayFunctionalityTest.testPlaceholders - History - More details - Source on GitHub
java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:632)
at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:716)
at java.base/java.util.Optional.orElseGet(Optional.java:364)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.RuntimeException: Failed to start quarkus
at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
⚙️ JVM Tests - JDK 21 #
- Failing: integration-tests/flyway
📦 integration-tests/flyway
✖ io.quarkus.it.flyway.FlywayFunctionalityTest.testPlaceholders - History - More details - Source on GitHub
java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:632)
at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:716)
at java.base/java.util.Optional.orElseGet(Optional.java:364)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.RuntimeException: Failed to start quarkus
at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
⚙️ Native Tests - Data3 #
- Failing: integration-tests/flyway
📦 integration-tests/flyway
✖ io.quarkus.it.flyway.FlywayFunctionalityNativeIT.testPlaceholders - History - More details - Source on GitHub
java.lang.RuntimeException: java.lang.RuntimeException: Unable to successfully launch process '5883'. Exit code is: '1'.
at io.quarkus.test.junit.QuarkusIntegrationTestExtension.throwBootFailureException(QuarkusIntegrationTestExtension.java:375)
at io.quarkus.test.junit.QuarkusIntegrationTestExtension.beforeEach(QuarkusIntegrationTestExtension.java:118)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: java.lang.RuntimeException: Unable to successfully launch process '5883'. Exit code is: '1'.
at io.quarkus.test.common.LauncherUtil.ensureProcessIsAlive(LauncherUtil.java:124)
at io.quarkus.test.common.LauncherUtil.waitForCapturedListeningData(LauncherUtil.java:87)
|
The failure looks related to usage of public schema in tests (see below). Since it's mentioned in #41862, I assume the public schema can no longer be used by default in Postgres 16. |
It was a red herring. Flyway was reporting something like "Version X of Postgres not supported" when the version was irrelevant: it was the general postgres support module that was missing, but I'm pretty sure some brave colleague fixed that. |
|
I will close this one and create a more comprehensive PR with some Flyway tests adjustments and maybe also some other image updates. |
|
Superseded by #44191 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #44150
anyone know if reason to stay on older postgres or this should be fine?