Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NettyProcessor documentation and update #43654

Merged

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Oct 2, 2024

  • Add comments explaining the NettyProcessor native-image config
  • Refactor HttpContentCompressorSubstitutions for consistency
  • Remove obsolete runtime initialization of netty classes

Creating as draft to test in my fork.

@zakkak
Copy link
Contributor Author

zakkak commented Oct 2, 2024

integration-tests/devtools fails due to #43662 being triggered at build time, see https://github.com/zakkak/quarkus/actions/runs/11144505742/job/30972921818#step:16:4357

I will revert https://github.com/quarkusio/quarkus/pull/43654/files#diff-305a2796c8e31d213fe9b9b4d2162ee30f45471241fa06e8741acf15c324a4b6R147 to keep BrotliOptions runtime initialized even when the library is present for the time being (to avoid the CI failures, despite it revealing an actual issue).

@zakkak zakkak force-pushed the 2024-10-02-document-netty-native-config branch from 3ef34d3 to 058eb14 Compare October 4, 2024 14:43
@zakkak zakkak marked this pull request as ready for review October 4, 2024 18:22
@zakkak
Copy link
Contributor Author

zakkak commented Oct 4, 2024

Best reviewed per commit.

@franz1981 you might find the documentation part interesting/helpful.

Copy link

quarkus-bot bot commented Oct 5, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 058eb14.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Native Tests - Messaging1

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorIT.testRequestReply - History

  • iterable contents differ at index [2], expected: <reply-3> but was: <{"details":"Error id 23a0acc7-d4ab-4c9c-9414-89394c4e4e9c-1","stack":""}> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: iterable contents differ at index [2], expected: <reply-3> but was: <{"details":"Error id 23a0acc7-d4ab-4c9c-9414-89394c4e4e9c-1","stack":""}>
	at io.quarkus.it.kafka.KafkaConnectorTest.testRequestReply(KafkaConnectorTest.java:112)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:810)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@gsmet gsmet merged commit a6b314a into quarkusio:main Oct 8, 2024
67 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Oct 8, 2024
@gsmet
Copy link
Member

gsmet commented Oct 8, 2024

Thanks, that's indeed a good idea given how complex this thing is!

@zakkak zakkak deleted the 2024-10-02-document-netty-native-config branch October 8, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants