Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show nicer error when a @ConfigMapping class exists in the deployment module and set to the runtime phase #43513

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Sep 26, 2024

Copy link

quarkus-bot bot commented Sep 26, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@mcruzdev mcruzdev closed this Sep 26, 2024
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Sep 26, 2024
@mcruzdev mcruzdev reopened this Sep 26, 2024
@quarkus-bot quarkus-bot bot removed the triage/invalid This doesn't seem right label Sep 26, 2024
@mcruzdev
Copy link
Contributor Author

mcruzdev commented Sep 26, 2024

Hi @radcortez, could you see if I am in the right path? Any suggestions are welcome!

@mcruzdev mcruzdev marked this pull request as ready for review September 26, 2024 19:01
@radcortez
Copy link
Member

Thank you for the PR; I've left a few comments.

This comment has been minimized.

Copy link
Member

@radcortez radcortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI failure is related.

Copy link
Member

@radcortez radcortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test please? Thank you.

@mcruzdev
Copy link
Contributor Author

mcruzdev commented Oct 4, 2024

Can we add a test please? Thank you.

Sorry for delay @radcortez, I will use this wekeend to add it!

@mcruzdev mcruzdev force-pushed the issue-43394 branch 2 times, most recently from 272657c to c396af0 Compare October 5, 2024 16:40
@mcruzdev mcruzdev requested a review from radcortez October 12, 2024 17:53

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Dec 1, 2024

Looks like CI is passing! Could you squash the commits?

I'm traveling for 2 days, will have a look after that if noone beats me to it.

@radcortez
Copy link
Member

I'm traveling for 2 days, will have a look after that if noone beats me to it.

Don't worry about it. I'll have a look.

@mcruzdev
Copy link
Contributor Author

mcruzdev commented Dec 1, 2024

Looks like CI is passing! Could you squash the commits?

Done!

This comment has been minimized.

This comment has been minimized.

@radcortez
Copy link
Member

I gave it a try, and it worked as expected. I think this last implementation is way better than what we had before.

Thank you for the work and patience @mcruzdev

@radcortez radcortez added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 3, 2024
@mcruzdev
Copy link
Contributor Author

mcruzdev commented Dec 3, 2024

I gave it a try, and it worked as expected. I think this last implementation is way better than what we had before.

Thank you for the work and patience @mcruzdev

I am the one who is grateful :)

Copy link

quarkus-bot bot commented Dec 12, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit c43e0dc.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Dec 12, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c43e0dc.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit e2db51c into quarkusio:main Dec 13, 2024
54 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Dec 13, 2024
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show nicer error when a @ConfigMapping class exists in the deployment module and set to the runtime phase
5 participants