-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing sourceSets for Kotlin in Project Descriptor #43329
Missing sourceSets for Kotlin in Project Descriptor #43329
Conversation
|
||
import org.junit.jupiter.api.Test; | ||
|
||
public class KotlinIsIncludedInQuarkusJarTest extends QuarkusGradleWrapperTestBase { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in my fork, I created another branch to validate the purpose of this test by removing the included changes in ProjectDescriptorBuilder
, the result is:
2024-09-17T02:32:37.0846761Z org.opentest4j.AssertionFailedError: Expected entry basic-kotlin-application-project/src/main/kotlin/org/acme/MyMainClass.class not found in JAR file. ==> expected: <true> but was: <false>
2024-09-17T02:32:37.0849523Z at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
2024-09-17T02:32:37.0851336Z at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
2024-09-17T02:32:37.0853003Z at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
2024-09-17T02:32:37.0854351Z at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
2024-09-17T02:32:37.0855760Z at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
2024-09-17T02:32:37.0857660Z at io.quarkus.gradle.KotlinIsIncludedInQuarkusJarTest.assertJarContainsEntry(KotlinIsIncludedInQuarkusJarTest.java:45)
2024-09-17T02:32:37.0860012Z at io.quarkus.gradle.KotlinIsIncludedInQuarkusJarTest.testFastJarFormatWorks(KotlinIsIncludedInQuarkusJarTest.java:28)
2024-09-17T02:32:37.0861883Z at java.base/java.lang.reflect.Method.invoke(Method.java:569)
2024-09-17T02:32:37.0863187Z at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2024-09-17T02:32:37.0864658Z at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2024-09-17T02:32:37.0866574Z
Status for workflow
|
Thanks a lot for this!
|
This could also fix #43264. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @cdsap !
SourceSets for the Kotlin tasks were not included in the
ProjectDescriptorBuilder
(my mistake).This PR adds a new integrating test to verify that the Kotlin classes have been included in the jar.
Additional tests:
Comparing 3.13.1 vs 314.3, diff in the Kotlin classes:
Comparing 3.13.1 vs This PR, no diff in the Kotlin classes: