Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OidcEndpoint.Type for the dynamically registered client #43184

Merged

Conversation

sberyozkin
Copy link
Member

Minor update to the code currently on main only.

OidcEndpoint.Type can be used to restrict OidcRequestFilter, and soon, OidcResponseFilter, to filtering specific OIDC endpoints only.
As far as OIDC dynamic client registration is concerned, it can make calls to 2 endpoints:

  • the client registration endpoint (OidcEndpoint.Type: CLIENT_REGISTRATION).
  • the endpoint representing a newly registered client, where the client's configuration can be read again, or updated, or the whole client registration can be deleted. Currently this endpoint is represented by the OidcEndpoint.Type: CLIENT_CONFIGURATION endpoint type, but it does not feel quite right. PR proposes to change it to REGISTERED_CLIENT, to align with the RegisteredClient class name which manages the registered client

@sberyozkin sberyozkin force-pushed the oidc_endpoint_registered_client branch from 46f42b5 to e14412e Compare September 10, 2024 14:17
Copy link

quarkus-bot bot commented Sep 10, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e14412e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin sberyozkin merged commit e3b1b23 into quarkusio:main Sep 10, 2024
23 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 10, 2024
@sberyozkin sberyozkin deleted the oidc_endpoint_registered_client branch September 10, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants