Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Satisfy GraalVM's classpath needs for the deletion of org.h2.fulltext.FullTextLucene" #43131

Merged
merged 2 commits into from
Sep 9, 2024
+6 −10
Merged

Revert "Satisfy GraalVM's classpath needs for the deletion of org.h2.fulltext.FullTextLucene" #43131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df572ba
Revert "Satisfy GraalVM's classpath needs"
zakkak Sep 9, 2024
d7b0fdd
Augment `quarkus.native.report-errors-at-runtime` documentation
zakkak Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bom/application/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
<cronutils.version>9.2.1</cronutils.version>
<quartz.version>2.3.2</quartz.version>
<h2.version>2.3.232</h2.version> <!-- When updating, needs to be matched in io.quarkus.hibernate.orm.runtime.config.DialectVersions
and dependencies jts-core and lucene-core need to be updated in extensions/jdbc/jdbc-h2/runtime/pom.xml -->
and the dependency jts-core needs to be updated in extensions/jdbc/jdbc-h2/runtime/pom.xml -->
<postgresql-jdbc.version>42.7.4</postgresql-jdbc.version>
<mariadb-jdbc.version>3.4.1</mariadb-jdbc.version>
<mysql-jdbc.version>8.3.0</mysql-jdbc.version>
Expand Down
5 changes: 5 additions & 0 deletions core/deployment/src/main/java/io/quarkus/deployment/pkg/NativeConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,11 @@ default String getEffectiveImage() {
* If errors should be reported at runtime. This is a more relaxed setting, however it is not recommended as it
* means
* your application may fail at runtime if an unsupported feature is used by accident.
*
* Note that the use of this flag may result in build time failures due to {@code ClassNotFoundException}s.
* Reason most likely being that the Quarkus extension already optimized it away or do not actually need it.
* In such cases you should explicitly add the corresponding dependency providing the missing classes as a
zakkak marked this conversation as resolved.
Show resolved Hide resolved
* dependency to your project.
*/
@WithDefault("false")
boolean reportErrorsAtRuntime();
Expand Down
9 changes: 0 additions & 9 deletions extensions/jdbc/jdbc-h2/runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,6 @@
<groupId>com.h2database</groupId>
<artifactId>h2</artifactId>
</dependency>
<dependency>
<!--
Needed by GraalVM to delete org.h2.fulltext.FullTextLucene
https://github.com/quarkusio/quarkus/issues/42228
-->
<groupId>org.apache.lucene</groupId>
<artifactId>lucene-core</artifactId>
<version>9.7.0</version>
</dependency>
<dependency>
<groupId>org.locationtech.jts</groupId>
<artifactId>jts-core</artifactId>
Expand Down
Loading