Small follow-up for @WithTestResource change #43004
Conversation
The semantic is that all the test resources have to match so let's use the plural form.
This comment was marked as resolved.
This comment was marked as resolved.
| * Note that when a restart is needed, all the resources will be restarted. | ||
| * This includes the global test resources and the Dev Services. | ||
| * <p> | ||
| * Quarkus groups the tests by test resources to reduce the number of restarts. |
There was a problem hiding this comment.
This is not true yet but I think we need to have it before we release 3.16.
/cc @famod - FWIW, I think a hash code of the sorted concatenation of resource classes would be enough. But we need to deal with multiple @WithTestResource and also with meta annotations.
| * Restarting Quarkus for this test means that the test resources will be restarted. | ||
| * This includes the global test resources and the Dev Services. |
There was a problem hiding this comment.
That's what makes me a bit unsure about the semantic.
The semantic is actually more about the test itself than about the attached test resources. This is even more obvious when you have global and non global test resources attached.
geoand
added
the
triage/waiting-for-ci
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✖ | Quickstarts Compilation - JDK 17 | Compile Quickstarts |
Failures | Logs | Raw logs | 🚧 |
You can consult the Develocity build scans.
Failures
⚙️ Quickstarts Compilation - JDK 17 #
- Failing: optaplanner-quickstart
📦 optaplanner-quickstart
✖ Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile (default-testCompile) on project optaplanner-quickstart: Compilation failure
/home/runner/work/quarkus/quarkus/quarkus-quickstarts/optaplanner-quickstart/src/test/java/org/acme/optaplanner/TestResources.java:[6,57] cannot find symbol
symbol: method restrictToAnnotatedClass()
location: @interface io.quarkus.test.common.WithTestResource
Flaky tests - Develocity
⚙️ JVM Tests - JDK 17
📦 extensions/smallrye-reactive-messaging/deployment
✖ io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History
Expecting actual: ["-4","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"]-java.lang.AssertionError
java.lang.AssertionError:
Expecting actual:
["-4","-5","-6","-7","-8","-9","-10","-11"]
to start with:
["-3", "-4", "-5", "-6"]
at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)
quarkus-bot
bot
removed
the
triage/waiting-for-ci
No description provided.