Fix connection port for MongoDB dev services using shared network #42472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hostname was fixed in quarkusio#42065 but when using a shared network and a container build, the application will connect directly to the container port so we shouldn't use the exposed port but the original one. Fixes quarkusio#42453
|
@cristianonicolai could you check this one? It's closely related to what you did in #42065 and I would like to make sure I didn't break your use case by fixing another one. Thanks! |
geoand
approved these changes
Aug 11, 2024
Status for workflow
|
|
@gsmet it looks ok to me |
|
Note that I think this all is failing when you reuse the containers. We will need more work to get this properly working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hostname was fixed in #42065 but when using a shared network and a container build, the application will connect directly to the container port so we shouldn't use the exposed port but the original one.
Fixes #42453