Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix section level for Varying database in Hibernate ORM #42373

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 7, 2024

No description provided.

@gsmet
Copy link
Member Author

gsmet commented Aug 7, 2024

See the TOC here: https://quarkus.io/guides/hibernate-orm

Copy link
Contributor

@marko-bekhta marko-bekhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 yeah, this section should definitely not jump to the top level 🙈
Reading through it a couple of times I was thinking that maybe I'd make it a very long [WARNING]/[NOTE] ... 😄 but let's keep it as a section 😃

It's nice that you've noticed it! 🎉

Copy link

quarkus-bot bot commented Aug 7, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit cb8fe2c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit dec2e80 into quarkusio:main Aug 7, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Aug 7, 2024
@gsmet
Copy link
Member Author

gsmet commented Aug 7, 2024

@marko-bekhta yeah I don't mind you making it a warning for sure.

Copy link

github-actions bot commented Aug 7, 2024

🙈 The PR is closed and the preview is expired.

@gsmet gsmet modified the milestones: 3.14 - main, 3.13.2 Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants