Introduce `@UnwrapException` for Quarkus REST #42094

geoand · 2024-07-24T06:53:58Z

This allows users to configure exceptions
whose cause will be checked against exception mappers.

This capability already existed in Quarkus REST and was used to map some internal exceptions, but with the new annotation users can opt into the feature for whatever exceptions make sense for their use case.

Closes: Customize list of exceptions to unwrap in resteasy-reactive #42089

FroMage · 2024-07-30T10:09:38Z

...eactive/server/runtime/src/main/java/org/jboss/resteasy/reactive/server/UnwrapException.java

+ * Used to configure that an exception (or exceptions) should be unwrapped during exception handling.
+ * <p>
+ * Unwrapping means that when an {@link Exception} of the configured type is thrown and no
+ * {@code jakarta.ws.rs.ext.ExceptionMapper} exists,


This is a bit subtle. This unwrapping only happens when there's no registered mapper for the direct exception type?

Do you think this should be mentioned in the docs? (The guide, not just the javadoc)

It is implied, no?

I did not find it implied, no. How I read it was that the minute we declare that an exception should be unwrapped, it will never match an exceptoin mapper.

If you want to push an update with what you have in mind, I'm perfectly fine with that

I'm not sure how to phrase this in the docs, especially given that it's already a TIP followed by a NOTE, I feel like this succession of tips/notes should be turned into sub-sections :-/

Also, I'm now realising that it should probably be a warning (or error?) if we have both an exception mapper for T and an unwrap exception for T, no? In this case, the exception will never be unwrapped.

Also, I'm now realising that it should probably be a warning (or error?) if we have both an exception mapper for T and an unwrap exception for T, no? In this case, the exception will never be unwrapped.

Yeah, that can be a good follow-up

I'm not sure how to phrase this in the docs, especially given that it's already a TIP followed by a NOTE, I feel like this succession of tips/notes should be turned into sub-sections :-/

Yeah, very likely so.

docs/src/main/asciidoc/rest.adoc

This allows users to configure exceptions whose cause will be checked against exception mappers. This capability already existed in Quarkus REST and was used to map some internal exceptions, but with the new annotation users can opt into the feature for whatever exceptions make sense for their use case. Closes: quarkusio#42089

quarkus-bot · 2024-07-30T12:23:10Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit f743fa4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot · 2024-07-30T15:03:30Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit f743fa4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/opentelemetry

✖ io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.testOTelInjections - History

Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.reset(OpenTelemetryInjectionsTest.java:26)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

⚙️ JVM Tests - JDK 21

📦 extensions/micrometer/deployment

✖ io.quarkus.micrometer.deployment.binder.VertxTcpMetricsNoClientMetricsTest.testTcpMetricsWithoutClientMetrics - History

event executor terminated - java.util.concurrent.RejectedExecutionException

java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:931)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:350)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:343)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:833)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:824)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:814)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

📦 integration-tests/opentelemetry

✖ io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.testOTelInjections - History

Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.OpenTelemetryInjectionsTest.reset(OpenTelemetryInjectionsTest.java:26)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

geoand · 2024-07-30T15:12:19Z

@FroMage I am going to merge this one and we can improve the docs in later PRs

github-actions · 2024-07-30T15:12:50Z

🙈 The PR is closed and the preview is expired.

geoand marked this pull request as ready for review July 24, 2024 06:54

quarkus-bot bot added the area/rest label Jul 24, 2024

geoand mentioned this pull request Jul 24, 2024

Customize list of exceptions to unwrap in resteasy-reactive #42089

Closed

This comment has been minimized.

Sign in to view

geoand force-pushed the #42089 branch from b13d7dc to e0f89ee Compare July 24, 2024 07:05

This comment has been minimized.

Sign in to view

quarkus-bot bot added the triage/flaky-test label Jul 24, 2024

geoand requested a review from gsmet July 24, 2024 10:19

geoand force-pushed the #42089 branch from e0f89ee to c125e16 Compare July 24, 2024 12:29

quarkus-bot bot added the area/documentation label Jul 24, 2024

This comment has been minimized.

Sign in to view

geoand force-pushed the #42089 branch from c125e16 to 504e8e9 Compare July 24, 2024 13:15

This comment has been minimized.

Sign in to view

geoand requested a review from gastaldi July 30, 2024 07:24

FroMage approved these changes Jul 30, 2024

View reviewed changes

geoand force-pushed the #42089 branch from 504e8e9 to f743fa4 Compare July 30, 2024 11:54

geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 30, 2024

FroMage approved these changes Jul 30, 2024

View reviewed changes

geoand merged commit 53da33e into quarkusio:main Jul 30, 2024
49 checks passed

quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jul 30, 2024

quarkus-bot bot added this to the 3.14 - main milestone Jul 30, 2024

geoand deleted the #42089 branch July 30, 2024 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce `@UnwrapException` for Quarkus REST #42094

Introduce `@UnwrapException` for Quarkus REST #42094

geoand commented Jul 24, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

FroMage Jul 30, 2024

geoand Jul 30, 2024

FroMage Jul 30, 2024

geoand Jul 30, 2024

FroMage Jul 30, 2024

geoand Jul 30, 2024

FroMage Jul 30, 2024

geoand Jul 30, 2024

geoand Jul 30, 2024

quarkus-bot bot commented Jul 30, 2024

quarkus-bot bot commented Jul 30, 2024 •

edited by github-actions bot

Loading

geoand commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

Introduce @UnwrapException for Quarkus REST #42094

Introduce @UnwrapException for Quarkus REST #42094

Conversation

geoand commented Jul 24, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

quarkus-bot bot commented Jul 30, 2024

Status for workflow Quarkus Documentation CI

quarkus-bot bot commented Jul 30, 2024 • edited by github-actions bot Loading

Status for workflow Quarkus CI

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/opentelemetry

⚙️ JVM Tests - JDK 21

📦 extensions/micrometer/deployment

📦 integration-tests/opentelemetry

geoand commented Jul 30, 2024

github-actions bot commented Jul 30, 2024

Introduce `@UnwrapException` for Quarkus REST #42094

Introduce `@UnwrapException` for Quarkus REST #42094

Status for workflow `Quarkus Documentation CI`

quarkus-bot bot commented Jul 30, 2024 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`