Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conditionalization from Wiremock section #41977

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Jul 18, 2024

Remove :no-deprecated-test-resource[] conditionalization from Wiremock and OidcTestClient content in response to review comments such as:

#41834 (comment)
#41834 (comment)
#41834 (comment)
#41834 (comment)

I have also cherry-picked these changes to 3.8 with #41980.

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Jul 18, 2024
@rolfedh rolfedh force-pushed the remove-some-changes branch from 9d7c20f to 8da8697 Compare July 18, 2024 12:57
@rolfedh rolfedh requested a review from sberyozkin July 18, 2024 13:04
@rolfedh rolfedh marked this pull request as draft July 18, 2024 13:04
@rolfedh rolfedh requested a review from michalvavrik July 18, 2024 14:06
@rolfedh rolfedh marked this pull request as ready for review July 18, 2024 14:07
@rolfedh
Copy link
Contributor Author

rolfedh commented Jul 18, 2024

When all PRs are approved and merged in the following order, I should finally be able to synch and publish the Security Guides for RHBQ 3.8:

  1. [3.8] Apply QE feedback to community docs #41834
  2. Remove conditionalization from Wiremock section #41977
  3. [3.8] Remove conditionalization from Wiremock section #41980

@sberyozkin sberyozkin merged commit 6e0718e into quarkusio:main Jul 18, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 18, 2024
@sberyozkin sberyozkin deleted the remove-some-changes branch July 18, 2024 14:40
Copy link

🙈 The PR is closed and the preview is expired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
Development

Successfully merging this pull request may close these issues.

2 participants