Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR adds an optional OIDC client name property.
If set, it is expected to provide a nice, human readable description of the registered client/application.
Typically, with social providers or Keycloak, when we register applications,
Description
is what this client name property represents.As far as an immediate impact on Quarkus OIDC is concerned, it is only about logging a client name in a couple of places for now, if it is set. Users can also access it when creating Qute templates for creating HTMLs for interacting with users.
It is also relevant for the OIDC Dynamic client registration work which is underway now (see the
client_name
in https://openid.net/specs/openid-connect-registration-1_0.html#ClientMetadata and https://openid.net/specs/openid-connect-registration-1_0.html#RegistrationRequest), so when the OIDC client is registered automatically, Quarkus will setquarkus.oidc.client-name
itself, etcCC @calvernaz