Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC clientName property #41630

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

sberyozkin
Copy link
Member

This simple PR adds an optional OIDC client name property.

If set, it is expected to provide a nice, human readable description of the registered client/application.
Typically, with social providers or Keycloak, when we register applications, Description is what this client name property represents.

As far as an immediate impact on Quarkus OIDC is concerned, it is only about logging a client name in a couple of places for now, if it is set. Users can also access it when creating Qute templates for creating HTMLs for interacting with users.

It is also relevant for the OIDC Dynamic client registration work which is underway now (see the client_name in https://openid.net/specs/openid-connect-registration-1_0.html#ClientMetadata and https://openid.net/specs/openid-connect-registration-1_0.html#RegistrationRequest), so when the OIDC client is registered automatically, Quarkus will set quarkus.oidc.client-name itself, etc

CC @calvernaz

@sberyozkin sberyozkin requested review from gastaldi and pedroigor July 2, 2024 14:22
@quarkus-bot quarkus-bot bot added the area/oidc label Jul 2, 2024
Copy link

quarkus-bot bot commented Jul 2, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b482750.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin sberyozkin merged commit b042038 into quarkusio:main Jul 2, 2024
22 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 2, 2024
@sberyozkin sberyozkin deleted the oidc_client_name_config branch July 2, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants