Deprecate class cloning configuration #41623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #17306 the class cloning was made configurable, to make Pact work with Quarkus. With recent versions of Quarkus and the Pact extension, this config is not necessary. Even https://github.com/skattela/pact-workshop-jvm-quarkus, which is older, does not use the config.
I’ve searched through public codebases, and I do not believe this configuration is widely used. https://github.com/search?q=quarkus.test.class-clone-pattern%3D&type=code shows only 6 usages of quarkus.test.class-clone-pattern in configuration files, all in commented out boilerplate. Searching for the camel case version, CLASS_CLONE_PATTERN= gave no instances: https://github.com/search?q=CLASS_CLONE_PATTERN%3D&type=code
In my searches, I added the equals sign so filter out config documentation and forks of the quarkus repo, which do reference the property name.
Whether we explicitly remove the configurable part of the cloning process (#41621), or just remove the whole class cloning (#34681), we should get rid of this unused knob.