Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Flyway guide dependency section #41560

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Update Flyway guide dependency section #41560

merged 1 commit into from
Jul 1, 2024

Conversation

joaodsimoes
Copy link
Contributor

Fixes #40834 according to flyway/flyway#3780

@joaodsimoes
Update flyway.adoc
bad999b 
Updated flyway documentation according to issue flyway/flyway#3780
@joaodsimoes joaodsimoes changed the title Update flyway.adoc Update flyway guide's dependency section Jun 28, 2024
@joaodsimoes joaodsimoes changed the title Update flyway guide's dependency section Update Flyway guide dependency section Jun 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 28, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@FroMage
Copy link
Member

FroMage commented Jul 1, 2024

This has my +1 but @geoand said in #40834 that he can make the extra module automatically included, which would mean the docs would have to be updated again.

OTOH, we could merge this now, and deal with making it automatic later, WDYT @geoand ?

@geoand
Copy link
Contributor

geoand commented Jul 1, 2024

OTOH, we could merge this now, and deal with making it automatic later, WDYT @geoand ?

Sure yeah, let's do that

@geoand geoand merged commit 88db83a into quarkusio:main Jul 1, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.13 - main milestone Jul 1, 2024
@gsmet gsmet modified the milestones: 3.13 - main, 3.12.1 Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/documentation kind/bugfix
Projects
Quarkus Documentation
Status: Done
Milestone
3.12.1
Development

Successfully merging this pull request may close these issues.

Flyway documentation should mention required database modules
4 participants
@joaodsimoes @FroMage @geoand @gsmet