Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename confusing methods in CuratedApplication #41544

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Rename confusing methods in CuratedApplication #41544

merged 1 commit into from
Jul 1, 2024

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jun 28, 2024

And make sure we can log things in the QuarkusClassLoader constructor.

@aloubyansky another version of #41433

@gsmet
Rename confusing methods in CuratedApplication
b4bbb8a 
And make sure we can log things in the QuarkusClassLoader constructor.
@gsmet gsmet requested a review from aloubyansky June 28, 2024 09:05
@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/testing labels Jun 28, 2024
aloubyansky
aloubyansky approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

geoand
geoand approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 28, 2024
@geoand geoand merged commit 322d112 into quarkusio:main Jul 1, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees
No one assigned
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/testing triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsmet @aloubyansky @geoand