Simplify code in RestAssuredURLManager #41537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code still works whether RestAssured is on the classpath or not, but it now contains direct invocations of RestAssured code instead of reflection. It goes without saying that this make the class a lot more maintainable At some point in the future, we probably want to have some sort of SPI, but for now, this change is much better than the current state.
|
This should help with the changes for certificates that @cescoffier has in mind |
|
Oh thanks for this! The reflection code was becoming unmaintainable |
cescoffier
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code still works whether RestAssured is on the classpath or not, but it now contains direct invocations of RestAssured code instead of reflection.
It goes without saying that this make the class a lot more maintainable.
At some point in the future, we probably want to have some sort of SPI, but for now, this change is much better than the current state.