-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Hibernate ORM 6.6 / Search 7.2 / Reactive 2.4 #41359
Conversation
/cc @gsmet (hibernate-orm) |
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
0a6057d
to
ad1c35c
Compare
27874ea
to
4f4a04c
Compare
🎊 PR Preview c24efa8 has been successfully built and deployed to https://quarkus-pr-main-41359-preview.surge.sh/version/main/guides/
|
f9cf7cc
to
871be5f
Compare
This comment has been minimized.
This comment has been minimized.
It no longer has a purpose: 1. We removed the type caching in a previous commit, because it wasn't used anymore: ORM hasn't needed access to generator types at runtime for a while now. 2. StandardIdentifierGeneratorFactory has a constructor parameter to disable reliance on CDI, so we don't need to rewrite that code. 3. StandardIdentifierGeneratorFactory is registering custom generators itself, so we don't need to make `register` public to register them externally.
Since the database is not available during static init, the connection provider is just a stub that will fail on connection retrieval. This doesn't change anything functionally, but is a safer setup that will avoid problems such as the one we have with logging of DB info: https://hibernate.zulipchat.com/#narrow/stream/132094-hibernate-orm-dev/topic/HHH-18224.20Log.20DB.20info
This reverts commit 20940a5.
I rebased, updated to the Final versions and force pushed. |
thanks! 🎉 |
I added the content written by Yoann to the migration guide. |
Status for workflow
|
Work in progress; we need releases of ORM, Search and Reactive before we can merge this.=> DoneHere's what we will need to add to the migration guide: