-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work around config doc issues for LGTM #41291
Conversation
Status for workflow
|
...lity-devservices/common/src/main/java/io/quarkus/observability/common/config/LgtmConfig.java
Outdated
Show resolved
Hide resolved
The hierarchy stuff, with dups, was to handle previous behavior, which didn't know about hierarchy. |
Otherwise, this LGTM (pun intended ;-). |
I have a vague idea that we have some issue with that, but I can't remember exactly. Regardless, I believe any hierarchy mapping should work just fine. |
There are several issues: - first, the config doc processor is part of the extension processor for now, so you need to run it to analyze the config. - second we need to mark at least one class with @ConfigMapping, otherwise the config groups cannot be analyzed as part of config mappings. This will go away in the future. - then, the hierarchy here is quite weird with some methods overriding others, which is fine, except this is not properly handled in the config doc generator. For now, I just ignored the ones from the parent, but ideally, we should override them properly in the config doc generator. - also I removed some inherited methods from GrafanaConfig and I'm not yet sure if it will break something so creating as draft.
There are several issues:
Fixes #41285