Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OIDC warning when a session encryption key is generated #40916

Conversation

sberyozkin
Copy link
Member

No description provided.

This comment has been minimized.

@sberyozkin sberyozkin force-pushed the improve_oidc_encryption_key_generated_warn branch from ce5c445 to e2ca1f1 Compare May 31, 2024 10:38

This comment has been minimized.

@sberyozkin
Copy link
Member Author

That is strange, I actually run and built it...

@sberyozkin
Copy link
Member Author

@gsmet I'm struggling with fixing this formatting issue.

mvn clean install -DskipTests build does not fix it.

mvn -f extensions/oidc/runtime net.revelc.code.formatter:formatter-maven-plugin:2.24.0:format

gives

running `[WARNING] This build will only read from the build cache, since the clean lifecycle is not part of the build invocation.

and also does not fix it.

How can I remove the build cache ?

@Eng-Fouad
Copy link
Contributor

@gsmet I'm struggling with fixing this formatting issue.

mvn clean install -DskipTests build does not fix it.

mvn -f extensions/oidc/runtime net.revelc.code.formatter:formatter-maven-plugin:2.24.0:format

gives

running `[WARNING] This build will only read from the build cache, since the clean lifecycle is not part of the build invocation.

and also does not fix it.

How can I remove the build cache ?

See: #40945

@gsmet gsmet force-pushed the improve_oidc_encryption_key_generated_warn branch from e2ca1f1 to 8cf8663 Compare June 6, 2024 14:57
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sberyozkin I fixed it.

Let's make sure CI passes and we can merge.

@gsmet gsmet added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport labels Jun 6, 2024
Copy link

quarkus-bot bot commented Jun 6, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 8cf8663.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin
Copy link
Member Author

Thanks @gsmet

@sberyozkin sberyozkin merged commit 9222682 into quarkusio:main Jun 6, 2024
23 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 6, 2024
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone Jun 6, 2024
@sberyozkin sberyozkin deleted the improve_oidc_encryption_key_generated_warn branch June 6, 2024 16:26
@gsmet gsmet modified the milestones: 3.12 - main, 3.11.2 Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants