Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC: initial documentation of CDI pitfalls with reactive programming #40620

Merged
merged 1 commit into from
May 14, 2024
Merged

ArC: initial documentation of CDI pitfalls with reactive programming #40620

merged 1 commit into from
May 14, 2024

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented May 14, 2024

No description provided.

@Ladicek Ladicek requested review from mkouba and manovotn May 14, 2024 11:19
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited
Loading

🙈 The PR is closed and the preview is expired.

mkouba
mkouba reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start!

docs/src/main/asciidoc/cdi-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/cdi-reference.adoc Show resolved Hide resolved
docs/src/main/asciidoc/cdi-reference.adoc Outdated Show resolved Hide resolved
@Ladicek Ladicek force-pushed the cdi-reactive-pitfalls branch from 43e4159 to 7a06a23 Compare May 14, 2024 12:22
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented May 14, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 7a06a23.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

manovotn
manovotn approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good write-up.
I'd merge it as-is and expand on it as we encounter more cases in the future.

@mkouba mkouba merged commit 1f5c36f into quarkusio:main May 14, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 14, 2024
@Ladicek Ladicek deleted the cdi-reactive-pitfalls branch May 15, 2024 06:41
maxandersen
maxandersen reviewed May 16, 2024
View reviewed changes
docs/src/main/asciidoc/cdi-reference.adoc
== Pitfalls with Reactive Programming

CDI is a purely synchronous framework.
Its notion of asynchrony is very limited and based solely on thread pools and thread offloading.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that the case for async event/observers ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That's the only place in CDI where asynchrony is mentioned, and it's based on thread offloading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxandersen maxandersen maxandersen left review comments

@manovotn manovotn manovotn approved these changes

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
Quarkus Documentation
Status: Done
Milestone
3.11.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@Ladicek @maxandersen @mkouba @manovotn