Initial version of Dev UI Dependencies menu item #40481
Conversation
quarkus.bootstrap.incubating-model-resolver In collaboration with Phillip Kruger <[email protected]>
| private static void logPaths(List<DepPath> paths, String title) { | ||
| System.out.println(title + " total: " + paths.size()); | ||
| int j = 1; | ||
| for (var dp : paths) { | ||
| System.out.println(j++ + ") " + dp); | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe this should be removed ?
There was a problem hiding this comment.
This will be logged only if the shortest common paths are enabled, which is for now hardcoded to false.
| return; | ||
| } | ||
| if (node.dependents.isEmpty()) { | ||
| System.out.println(node.resolvedDep.getArtifactId() + " has no dependents"); |
There was a problem hiding this comment.
Remove or change to using Logger ?
There was a problem hiding this comment.
Same as above. I can change it to use proper logger API but this code isn't running currently anyway.
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✔️ | Native Tests - HTTP | Failures | Logs | Raw logs | 🚧 |
Failures
⚙️ Native Tests - HTTP #
- Failing: integration-tests/rest-client
📦 integration-tests/rest-client
✖ Failed to execute goal uk.co.automatictester:truststore-maven-plugin:3.0.0:generate-truststore (self-signed-truststore) on project quarkus-integration-test-rest-client: Execution self-signed-truststore of goal uk.co.automatictester:truststore-maven-plugin:3.0.0:generate-truststore failed: Unable to establish TLS connection with: self-signed.badssl.com:443
Flaky tests - Develocity
⚙️ JVM Tests - JDK 17
📦 extensions/smallrye-reactive-messaging-kafka/deployment
✖ io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds.-org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException:
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase
Expecting size of:
[]
to be greater than or equal to 2 but was 0 within 10 seconds.
at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
| Root root = new Root(); | ||
| root.rootId = curateOutcomeBuildItem.getApplicationModel().getAppArtifact().toCompactCoords(); | ||
| Set<String> allGavs = new TreeSet<>(); | ||
| buildTree(curateOutcomeBuildItem.getApplicationModel(), root, Optional.of(allGavs), Optional.empty()); |
There was a problem hiding this comment.
My understanding is that we will always execute this in dev mode once we switch to the new incubating model.
Question: how slow is it?
There was a problem hiding this comment.
Good point. It's not really slow but would be good to avoid it. @phillip-kruger could we avoid it until we get a click on "Dependencies"?
There was a problem hiding this comment.
We can, we then need to move it from build time, where we do this at the moment, to runtime. Let me know if you want to change that and we can do it that way
This menu item gets enabled when
quarkus.bootstrap.incubating-model-resolveroption istrue(has to be set either in apom.xmlor as a system property).In collaboration with Phillip Kruger [email protected]