Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenTelemetry End User attributes added as Span attributes #40466

Merged

Conversation

Copy link

quarkus-bot bot commented May 5, 2024

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/fix-otel-end-user-attrs branch from 3f05406 to e42fd42 Compare May 5, 2024 18:57
Copy link

github-actions bot commented May 5, 2024

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

This comment has been minimized.

@michalvavrik
Copy link
Member Author

/cc @geoand @sberyozkin

If you want, please review.

@geoand geoand requested review from brunobat and radcortez May 6, 2024 08:59
@geoand
Copy link
Contributor

geoand commented May 6, 2024

This is mostly for @brunobat and @radcortez to review.

@michalvavrik
Copy link
Member Author

michalvavrik commented May 6, 2024

This is mostly for @brunobat and @radcortez to review.

I know, I just wanted to give you opportunity to speak out because you had concerns about previous implementation and reliability of the feature. np @geoand

@geoand
Copy link
Contributor

geoand commented May 6, 2024

Thanks.

I wish I could remember what those were about to be honest 😄

@michalvavrik michalvavrik force-pushed the feature/fix-otel-end-user-attrs branch 2 times, most recently from b4a152e to aa8da2c Compare May 7, 2024 15:53

This comment has been minimized.

@michalvavrik michalvavrik requested a review from brunobat May 7, 2024 16:48

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/fix-otel-end-user-attrs branch from aa8da2c to acd3ca7 Compare May 8, 2024 15:38

This comment has been minimized.

Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michalvavrik
The tests are now intuitive. Thanks very much for the effort.

This comment has been minimized.

@michalvavrik
Copy link
Member Author

michalvavrik commented May 8, 2024

Ad org.eclipse.microprofile.telemetry.tracing.tck.async.JaxRsClientAsyncTest failure - Develocity says there are 15 results in last 7 days, 14 passed, 1 failed. That seems suspicious, but this feature must be activated at build time to have any effect at all. And it is disabled by default (there is a test to verify this).

Considering it passed last time and I only changed tests, documentation and rebased on current main, I don't think it can be related.

@michalvavrik
Copy link
Member Author

I'll retrigger CI just to be safe.

@michalvavrik michalvavrik force-pushed the feature/fix-otel-end-user-attrs branch from acd3ca7 to 238c37b Compare May 8, 2024 16:51
Copy link

quarkus-bot bot commented May 8, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 238c37b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented May 8, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 238c37b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@michalvavrik
Copy link
Member Author

ping @radcortez

@brunobat brunobat merged commit 455ec6c into quarkusio:main May 17, 2024
31 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone May 17, 2024
Copy link

quarkus-bot bot commented May 17, 2024

Milestone is already set for some of the items:

We haven't automatically updated the milestones for these items.

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added kind/bugfix kind/enhancement New feature or request labels May 17, 2024
@michalvavrik michalvavrik deleted the feature/fix-otel-end-user-attrs branch May 17, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants