-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OpenTelemetry End User attributes added as Span attributes #40466
Support OpenTelemetry End User attributes added as Span attributes #40466
Conversation
michalvavrik
commented
May 5, 2024
•
edited
Loading
edited
- Closes: OTEL - Automatic ENDUSER_ID and ENDUSER_ROLE filling #34526
- Closes: OpenTelemetry Extension not reliably adding user id and roles to span attributes #39563
- Closes: JWT+REST Client+OT: SecurityIdentityProxy exception popping up #39667
/cc @brunobat (opentelemetry), @radcortez (opentelemetry) |
This comment has been minimized.
This comment has been minimized.
3f05406
to
e42fd42
Compare
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
/cc @geoand @sberyozkin If you want, please review. |
This is mostly for @brunobat and @radcortez to review. |
I know, I just wanted to give you opportunity to speak out because you had concerns about previous implementation and reliability of the feature. np @geoand |
Thanks. I wish I could remember what those were about to be honest 😄 |
...ry/deployment/src/main/java/io/quarkus/opentelemetry/deployment/tracing/TracerProcessor.java
Outdated
Show resolved
Hide resolved
...entelemetry-reactive/src/main/java/io/quarkus/it/opentelemetry/reactive/EndUserResource.java
Outdated
Show resolved
Hide resolved
...entelemetry-reactive/src/main/java/io/quarkus/it/opentelemetry/reactive/EndUserResource.java
Outdated
Show resolved
Hide resolved
...entelemetry-reactive/src/main/java/io/quarkus/it/opentelemetry/reactive/EndUserResource.java
Outdated
Show resolved
Hide resolved
...entelemetry-reactive/src/main/java/io/quarkus/it/opentelemetry/reactive/EndUserResource.java
Show resolved
Hide resolved
b4a152e
to
aa8da2c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
...reactive/src/test/java/io/quarkus/it/opentelemetry/reactive/enduser/AbstractEndUserTest.java
Outdated
Show resolved
Hide resolved
aa8da2c
to
acd3ca7
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michalvavrik
The tests are now intuitive. Thanks very much for the effort.
This comment has been minimized.
This comment has been minimized.
Ad Considering it passed last time and I only changed tests, documentation and rebased on current main, I don't think it can be related. |
I'll retrigger CI just to be safe. |
acd3ca7
to
238c37b
Compare
Status for workflow
|
Status for workflow
|
ping @radcortez |
Milestone is already set for some of the items: We haven't automatically updated the milestones for these items. This message is automatically generated by a bot. |