Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump scala.version from 2.13.13 to 2.13.14 #40379

Merged
merged 1 commit into from
May 1, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 30, 2024

Bumps scala.version from 2.13.13 to 2.13.14.
Updates org.scala-lang:scala-reflect from 2.13.13 to 2.13.14

Commits
  • a527019 Merge pull request #10758 from som-snytt/fix/repl-color-redux
  • a064a89 Minimize diff for isTerminal probe
  • 6b68db9 Merge pull request #10739 from som-snytt/issue/9609-doc-doc-options
  • 83332ad Merge pull request #10755 from lrytz/10704-followup
  • fcf69c4 Merge pull request #10753 from som-snytt/test/fixup
  • 698369d Align WConf category for WFlagUnnamedBooleanLiteral
  • eea7029 Move terminal test to properties
  • b68ac48 Merge pull request #10751 from som-snytt/sd/867-jdk22-tests
  • 2c78ad2 Console color only if JDK 22 says isConsole
  • 770e6a0 Merge pull request #10749 from SethTisue/skip-jdeps-on-jdk-22
  • Additional commits viewable in compare view

Updates org.scala-lang:scala-library from 2.13.13 to 2.13.14

Commits
  • a527019 Merge pull request #10758 from som-snytt/fix/repl-color-redux
  • a064a89 Minimize diff for isTerminal probe
  • 6b68db9 Merge pull request #10739 from som-snytt/issue/9609-doc-doc-options
  • 83332ad Merge pull request #10755 from lrytz/10704-followup
  • fcf69c4 Merge pull request #10753 from som-snytt/test/fixup
  • 698369d Align WConf category for WFlagUnnamedBooleanLiteral
  • eea7029 Move terminal test to properties
  • b68ac48 Merge pull request #10751 from som-snytt/sd/867-jdk22-tests
  • 2c78ad2 Console color only if JDK 22 says isConsole
  • 770e6a0 Merge pull request #10749 from SethTisue/skip-jdeps-on-jdk-22
  • Additional commits viewable in compare view

Updates org.scala-lang:scala-compiler from 2.13.13 to 2.13.14

Commits
  • a527019 Merge pull request #10758 from som-snytt/fix/repl-color-redux
  • a064a89 Minimize diff for isTerminal probe
  • 6b68db9 Merge pull request #10739 from som-snytt/issue/9609-doc-doc-options
  • 83332ad Merge pull request #10755 from lrytz/10704-followup
  • fcf69c4 Merge pull request #10753 from som-snytt/test/fixup
  • 698369d Align WConf category for WFlagUnnamedBooleanLiteral
  • eea7029 Move terminal test to properties
  • b68ac48 Merge pull request #10751 from som-snytt/sd/867-jdk22-tests
  • 2c78ad2 Console color only if JDK 22 says isConsole
  • 770e6a0 Merge pull request #10749 from SethTisue/skip-jdeps-on-jdk-22
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `scala.version` from 2.13.13 to 2.13.14.

Updates `org.scala-lang:scala-reflect` from 2.13.13 to 2.13.14
- [Release notes](https://github.com/scala/scala/releases)
- [Commits](scala/scala@v2.13.13...v2.13.14)

Updates `org.scala-lang:scala-library` from 2.13.13 to 2.13.14
- [Release notes](https://github.com/scala/scala/releases)
- [Commits](scala/scala@v2.13.13...v2.13.14)

Updates `org.scala-lang:scala-compiler` from 2.13.13 to 2.13.14
- [Release notes](https://github.com/scala/scala/releases)
- [Commits](scala/scala@v2.13.13...v2.13.14)

---
updated-dependencies:
- dependency-name: org.scala-lang:scala-reflect
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.scala-lang:scala-library
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.scala-lang:scala-compiler
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the area/dependencies Pull requests that update a dependency file label Apr 30, 2024
@gastaldi gastaldi requested a review from gsmet May 1, 2024 00:47
@gastaldi
Copy link
Contributor

gastaldi commented May 1, 2024

I hope we can remove this extension soon from core and redirect Scala efforts to https://github.com/quarkiverse/quarkus-scala3

Copy link

quarkus-bot bot commented May 1, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e89123c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

⚙️ JVM Tests - JDK 17 Windows

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.BlockingRawTest.shouldAdd - History

  • Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)

@gsmet gsmet merged commit d657452 into main May 1, 2024
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.11 - main milestone May 1, 2024
@dependabot dependabot bot deleted the dependabot/maven/scala.version-2.13.14 branch May 1, 2024 10:40
@gsmet
Copy link
Member

gsmet commented May 1, 2024

IIRC, the problem is with codestarts. Language extensions are handled specifically and IIRC there are currently no ways to mark an extension as providing support for a language so that it's properly handled by codestarts.

If you're interested in making it happen, that would be awesome as we could drop this one, and also make the Groovy and Scala3 extensions better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file kind/component-upgrade triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants