-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebSockets Next: introduce OpenConnections #39858
Conversation
...websockets-next/server/runtime/src/main/java/io/quarkus/websockets/next/OpenConnections.java
Outdated
Show resolved
Hide resolved
...ockets-next/server/runtime/src/main/java/io/quarkus/websockets/next/WebSocketConnection.java
Outdated
Show resolved
Hide resolved
10933c0
to
efa66bc
Compare
This comment has been minimized.
This comment has been minimized.
...websockets-next/server/runtime/src/main/java/io/quarkus/websockets/next/OpenConnections.java
Outdated
Show resolved
Hide resolved
...websockets-next/server/runtime/src/main/java/io/quarkus/websockets/next/OpenConnections.java
Outdated
Show resolved
Hide resolved
efa66bc
to
0c1fede
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'd prefer to avoid the utility methods reusing the Stream since that can be done in the user's code, but that can be revisited in a later PR.
This comment has been minimized.
This comment has been minimized.
...websockets-next/server/runtime/src/main/java/io/quarkus/websockets/next/OpenConnections.java
Outdated
Show resolved
Hide resolved
...websockets-next/server/runtime/src/main/java/io/quarkus/websockets/next/OpenConnections.java
Outdated
Show resolved
Hide resolved
...websockets-next/server/runtime/src/main/java/io/quarkus/websockets/next/OpenConnections.java
Outdated
Show resolved
Hide resolved
...websockets-next/server/runtime/src/main/java/io/quarkus/websockets/next/OpenConnections.java
Outdated
Show resolved
Hide resolved
- also add WebSocket#endpointId() and WebSocketConnection#endpointId()
0c1fede
to
637a473
Compare
Well, I think that one of our goals is to help users write less code and these are typical operations a user might need, so why not add these tiny methods? 🤷 Anyway, I've renamed the methods, made the |
Status for workflow
|
See https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/websockets-next.3A.20more.20questions
CC @turing85