Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSockets Next: introduce OpenConnections #39858

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Apr 3, 2024

@mkouba mkouba force-pushed the websockets-next-open-connections branch from 10933c0 to efa66bc Compare April 3, 2024 13:37
@mkouba mkouba requested a review from cescoffier April 3, 2024 13:43
@mkouba mkouba marked this pull request as ready for review April 3, 2024 14:55
@mkouba mkouba requested a review from gastaldi April 3, 2024 14:55

This comment has been minimized.

@mkouba mkouba force-pushed the websockets-next-open-connections branch from efa66bc to 0c1fede Compare April 3, 2024 20:22
@mkouba mkouba requested a review from gastaldi April 3, 2024 20:22
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd prefer to avoid the utility methods reusing the Stream since that can be done in the user's code, but that can be revisited in a later PR.

This comment has been minimized.

- also add WebSocket#endpointId() and WebSocketConnection#endpointId()
@mkouba mkouba force-pushed the websockets-next-open-connections branch from 0c1fede to 637a473 Compare April 4, 2024 09:37
@mkouba
Copy link
Contributor Author

mkouba commented Apr 4, 2024

LGTM. I'd prefer to avoid the utility methods reusing the Stream since that can be done in the user's code, but that can be revisited in a later PR.

Well, I think that one of our goals is to help users write less code and these are typical operations a user might need, so why not add these tiny methods? 🤷

Anyway, I've renamed the methods, made the OpenConnections extend Iterable<WebSocketConnection> and added findByEndpointId()... so hopefully it's good to go now 😉.

@mkouba mkouba requested a review from gastaldi April 4, 2024 09:38
Copy link

quarkus-bot bot commented Apr 4, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 637a473.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@mkouba mkouba merged commit 243f46c into quarkusio:main Apr 4, 2024
19 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants