Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Vert.x 4.5.7 #39764

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Update to Vert.x 4.5.7 #39764

merged 2 commits into from
Mar 29, 2024

Conversation

jponge
Copy link
Member

@jponge jponge commented Mar 28, 2024

No description provided.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/vertx labels Mar 28, 2024
@jponge
Copy link
Member Author

jponge commented Mar 28, 2024

Backport note: 3.9 / 3.8 are based on Vert.x 4.5.x

@jponge
Copy link
Member Author

jponge commented Mar 28, 2024

I'm doing a separate 3.2 backport

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 28, 2024
@geoand
Copy link
Contributor

geoand commented Mar 28, 2024

Some GraalVM substitutions will definitely be needed to fix:

2024-03-28T10:04:40.0884388Z Fatal error: com.oracle.graal.pointsto.util.AnalysisError$ParsingError: Error encountered while parsing io.netty.handler.codec.http.HttpContentCompressor$ZstdEncoderFactory.createEncoder(HttpContentCompressor.java:459) 
2024-03-28T10:04:40.0886540Z Parsing context:
2024-03-28T10:04:40.0887601Z ------------------------------------------------------------------------------------------------------------------------
2024-03-28T10:04:40.0889390Z    at io.netty.handler.codec.http.HttpContentCompressor.beginEncode(HttpContentCompressor.java:275)
2024-03-28T10:04:40.0891458Z    at io.netty.handler.codec.http.HttpContentEncoder.encode(HttpContentEncoder.java:163)
2024-03-28T10:04:40.0895891Z    at io.netty.handler.codec.http.HttpContentEncoder.encode(HttpContentEncoder.java:57)
2024-03-28T10:04:40.0940626Z    at io.netty.handler.codec.MessageToMessageCodec$1.encode(MessageToMessageCodec.java:67)
2024-03-28T10:04:40.0941999Z                        15.5s (19.5% of total time) in 145 GCs | Peak RSS: 3.29GB | CPU load: 3.81
2024-03-28T10:04:40.0948157Z    at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:90)
2024-03-28T10:04:40.0950209Z    at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:893)
2024-03-28T10:04:40.0952128Z    at io.netty.channel.AbstractChannelHandlerContext.invokeWriteAndFlush(AbstractChannelHandlerContext.java:956)
2024-03-28T10:04:40.0954443Z    at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:982)
2024-03-28T10:04:40.0956098Z    at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:868)
2024-03-28T10:04:40.0957516Z    at io.vertx.core.net.impl.ConnectionBase.write(ConnectionBase.java:183)
2024-03-28T10:04:40.0958798Z    at io.vertx.core.net.impl.ConnectionBase.writeToChannel(ConnectionBase.java:233)
2024-03-28T10:04:40.0960126Z    at io.vertx.core.net.impl.ConnectionBase.writeClose(ConnectionBase.java:204)
2024-03-28T10:04:40.0961337Z    at io.vertx.core.net.impl.ConnectionBase.close(ConnectionBase.java:283)
2024-03-28T10:04:40.0962645Z    at io.vertx.core.http.impl.Http1xConnectionBase.close(Http1xConnectionBase.java:99)
2024-03-28T10:04:40.0964107Z    at io.vertx.core.http.impl.Http1xServerConnection.close(Http1xServerConnection.java:89)
2024-03-28T10:04:40.0965463Z    at io.vertx.core.net.impl.ConnectionBase.close(ConnectionBase.java:135)
2024-03-28T10:04:40.0966622Z    at io.vertx.core.net.impl.VertxHandler.close(VertxHandler.java:158)
2024-03-28T10:04:40.0968075Z    at io.netty.channel.AbstractChannelHandlerContext.invokeClose(AbstractChannelHandlerContext.java:757)
2024-03-28T10:04:40.0969805Z    at io.netty.channel.AbstractChannelHandlerContext.close(AbstractChannelHandlerContext.java:733)
2024-03-28T10:04:40.0971586Z    at io.netty.channel.AbstractChannelHandlerContext.close(AbstractChannelHandlerContext.java:560)
2024-03-28T10:04:40.0973072Z    at io.vertx.core.net.impl.VertxHandler.exceptionCaught(VertxHandler.java:138)
2024-03-28T10:04:40.0974752Z    at io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:346)
2024-03-28T10:04:40.0976633Z    at io.netty.channel.AbstractChannelHandlerContext.invokeRead(AbstractChannelHandlerContext.java:854)
2024-03-28T10:04:40.0978338Z    at io.netty.channel.AbstractChannelHandlerContext.read(AbstractChannelHandlerContext.java:824)
2024-03-28T10:04:40.0979886Z    at io.netty.channel.DefaultChannelPipeline.read(DefaultChannelPipeline.java:1004)
2024-03-28T10:04:40.0981138Z    at io.netty.channel.AbstractChannel.read(AbstractChannel.java:290)
2024-03-28T10:04:40.0982388Z    at io.netty.channel.DefaultChannelConfig.setAutoRead(DefaultChannelConfig.java:341)
2024-03-28T10:04:40.0983860Z    at io.netty.channel.socket.nio.NioDatagramChannelConfig.setAutoRead(NioDatagramChannelConfig.java:178)
2024-03-28T10:04:40.0984857Z    at io.netty.channel.socket.nio.NioDatagramChannelConfig.setAutoRead(NioDatagramChannelConfig.java:36)
2024-03-28T10:04:40.0985743Z    at io.netty.channel.DefaultChannelConfig.setOption(DefaultChannelConfig.java:183)
2024-03-28T10:04:40.0986657Z    at io.netty.channel.socket.DefaultDatagramChannelConfig.setOption(DefaultDatagramChannelConfig.java:134)
2024-03-28T10:04:40.0987655Z    at io.netty.channel.socket.nio.NioDatagramChannelConfig.setOption(NioDatagramChannelConfig.java:216)
2024-03-28T10:04:40.0988543Z    at io.netty.bootstrap.AbstractBootstrap.setChannelOption(AbstractBootstrap.java:487)
2024-03-28T10:04:40.0989349Z    at io.netty.bootstrap.AbstractBootstrap.setChannelOptions(AbstractBootstrap.java:479)
2024-03-28T10:04:40.0990079Z    at io.netty.bootstrap.ServerBootstrap.init(ServerBootstrap.java:133)
2024-03-28T10:04:40.0990949Z    at io.quarkus.netty.runtime.graal.Target_io_netty_bootstrap_AbstractBootstrap.initAndRegister(NettySubstitutions.java:351)
2024-03-28T10:04:40.0991833Z    at io.netty.bootstrap.AbstractBootstrap.doBind(AbstractBootstrap.java:288)
2024-03-28T10:04:40.0992758Z    at io.netty.bootstrap.AbstractBootstrap.bind(AbstractBootstrap.java:284)
2024-03-28T10:04:40.0993578Z    at io.quarkus.vertx.http.runtime.VertxHttpRecorder.initializeVirtual(VertxHttpRecorder.java:1395)
2024-03-28T10:04:40.0994715Z    at io.quarkus.vertx.http.runtime.VertxHttpRecorder.startServer(VertxHttpRecorder.java:317)
2024-03-28T10:04:40.0995578Z    at io.quarkus.deployment.steps.VertxHttpProcessor$openSocket189362710.deploy_0(Unknown Source)
2024-03-28T10:04:40.0996564Z    at io.quarkus.deployment.steps.VertxHttpProcessor$openSocket189362710.deploy(Unknown Source)
2024-03-28T10:04:40.0997264Z    at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
2024-03-28T10:04:40.0997827Z    at io.quarkus.runtime.Application.start(Application.java:101)
2024-03-28T10:04:40.0998542Z    at io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:111)
2024-03-28T10:04:40.0999203Z    at io.quarkus.runtime.Quarkus.run(Quarkus.java:71)
2024-03-28T10:04:40.0999687Z    at io.quarkus.runner.GeneratedMain.main(Unknown Source)
2024-03-28T10:04:40.1000284Z    at com.oracle.svm.core.JavaMainWrapper.runCore0(JavaMainWrapper.java:237)
2024-03-28T10:04:40.1000950Z    at com.oracle.svm.core.JavaMainWrapper.doRun(JavaMainWrapper.java:293)
2024-03-28T10:04:40.1001827Z    at com.oracle.svm.core.code.IsolateEnterStub.JavaMainWrapper_run_5087f5482cc9a6abc971913ece43acb471d2631b(generated:0)
2024-03-28T10:04:40.1002550Z    at static root method.(Unknown Source)
2024-03-28T10:04:40.1002803Z 
2024-03-28T10:04:40.1003340Z 	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.util.AnalysisError.parsingError(AnalysisError.java:149)
2024-03-28T10:04:40.1004518Z 	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.flow.MethodTypeFlow.createFlowsGraph(MethodTypeFlow.java:184)
2024-03-28T10:04:40.1005738Z 	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.flow.MethodTypeFlow.ensureFlowsGraphCreated(MethodTypeFlow.java:153)
2024-03-28T10:04:40.1007051Z 	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.flow.MethodTypeFlow.getOrCreateMethodFlowsGraphInfo(MethodTypeFlow.java:111)
2024-03-28T10:04:40.1008498Z 	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.typestate.DefaultVirtualInvokeTypeFlow.onObservedUpdate(DefaultVirtualInvokeTypeFlow.java:114)
2024-03-28T10:04:40.1009768Z 	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.flow.TypeFlow.update(TypeFlow.java:620)
2024-03-28T10:04:40.1010763Z 	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.PointsToAnalysis$1.run(PointsToAnalysis.java:491)
2024-03-28T10:04:40.1011900Z 	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.util.CompletionExecutor.executeCommand(CompletionExecutor.java:187)
2024-03-28T10:04:40.1013151Z 	at org.graalvm.nativeimage.pointsto/com.oracle.graal.pointsto.util.CompletionExecutor.lambda$executeService$0(CompletionExecutor.java:171)
2024-03-28T10:04:40.1014230Z 	at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1423)
2024-03-28T10:04:40.1015008Z 	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:387)
2024-03-28T10:04:40.1015775Z 	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1312)
2024-03-28T10:04:40.1016539Z 	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1843)
2024-03-28T10:04:40.1017239Z 	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1808)
2024-03-28T10:04:40.1018021Z 	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:188)
2024-03-28T10:04:40.1020403Z Caused by: org.graalvm.compiler.java.BytecodeParser$BytecodeParserError: org.graalvm.compiler.debug.GraalError: com.oracle.svm.core.util.UserError$UserException: Class initialization of io.netty.handler.codec.compression.ZstdConstants failed. This error is reported at image build time because class io.netty.handler.codec.compression.ZstdConstants is registered for linking at image build time by command line and command line. Use the option 
2024-03-28T10:04:40.1022482Z 
2024-03-28T10:04:40.1022920Z     '--initialize-at-run-time=io.netty.handler.codec.compression.ZstdConstants'

@jponge
Copy link
Member Author

jponge commented Mar 28, 2024

I'll get back to this later today, I now need to unlock another Mutiny + Reactive Messaging PR for @ozangunalp

@geoand geoand removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 28, 2024
@jponge jponge force-pushed the vertx/4.5.7-upgrade branch from 1b4c0f3 to f41e7b4 Compare March 28, 2024 13:51
@jponge
Copy link
Member Author

jponge commented Mar 28, 2024

Just added a substitution to cut ZstdConstants ties to an optional library.

@jponge
Copy link
Member Author

jponge commented Mar 28, 2024

Note on backporting 3.2: we should move forward with a Vert.x 4.4.9 release by @vietj

This comment has been minimized.

Copy link

quarkus-bot bot commented Mar 28, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f41e7b4.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 Failures Logs Raw logs 🚧
✔️ JVM Tests - JDK 21 Logs Raw logs 🚧

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/reactive-mysql-client/deployment 
! Skipped: integration-tests/hibernate-reactive-mariadb integration-tests/hibernate-reactive-mysql integration-tests/hibernate-reactive-mysql-agroal-flyway and 1 more

📦 extensions/reactive-mysql-client/deployment

Failed to execute goal io.fabric8:docker-maven-plugin:0.44.0:build (docker-start) on project quarkus-reactive-mysql-client-deployment: Unable to pull 'docker.io/mariadb:10.11' from registry 'docker.io' : received unexpected HTTP status: 503 Service Unavailable


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 core/deployment

io.quarkus.deployment.dev.FileSystemWatcherTestCase.testFileSystemWatcher - History

  • expected: not <null> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: not <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:152)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertNotNull.failNull(AssertNotNull.java:49)
	at org.junit.jupiter.api.AssertNotNull.assertNotNull(AssertNotNull.java:35)
	at org.junit.jupiter.api.AssertNotNull.assertNotNull(AssertNotNull.java:30)
	at org.junit.jupiter.api.Assertions.assertNotNull(Assertions.java:304)
	at io.quarkus.deployment.dev.FileSystemWatcherTestCase.consumeEvents(FileSystemWatcherTestCase.java:172)

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
  • Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a Lambda expression in io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

⚙️ Maven Tests - JDK 17

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed - History

  • Lambda expression in io.quarkus.maven.it.DevMojoIT expected "58fbb355-abea-4c12-aa8e-7903fd773941" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Lambda expression in io.quarkus.maven.it.DevMojoIT expected "58fbb355-abea-4c12-aa8e-7903fd773941" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:712)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed - History

  • Lambda expression in io.quarkus.maven.it.DevMojoIT expected "58fbb355-abea-4c12-aa8e-7903fd773941" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Lambda expression in io.quarkus.maven.it.DevMojoIT expected "58fbb355-abea-4c12-aa8e-7903fd773941" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:712)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

⚙️ Maven Tests - JDK 17 Windows

📦 integration-tests/maven

io.quarkus.maven.it.TestMojoIT.testThatTheTestsAreReRunMultiModule - History

  • Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils was not fulfilled within 3 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.maven.it.continuoustesting.TestModeContinuousTestingMavenTestUtils.waitForNextCompletion(TestModeContinuousTestingMavenTestUtils.java:49)
	at io.quarkus.maven.it.LaunchMojoTestBase.testThatTheTestsAreReRunMultiModule(LaunchMojoTestBase.java:56)

@geoand geoand merged commit 789ff56 into quarkusio:main Mar 29, 2024
49 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Mar 29, 2024
@jponge
Copy link
Member Author

jponge commented Mar 29, 2024

@geoand I'll work on the 3.2 backport later today following the release of Vert.x 4.4.9 (thanks @vietj!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/vertx triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants