Remove `org.graalvm.polyglot:polyglot` from classpath when using Mandrel 23.0 #39397

zakkak · 2024-03-13T11:20:48Z

Mandrel 23.0 ships with org.graalvm.polyglot:polyglot embedded and
adding it to the classpath results in an error.

Closes #39322

@jerboaa please review.

zakkak · 2024-03-13T11:28:35Z

CI run with Mandrel 23.0: https://github.com/graalvm/mandrel/actions/runs/8264180082

jerboaa

Seems OK to me. Have you tested this with some polyglot-using app and 23.0?

zakkak · 2024-03-13T13:55:47Z

Seems OK to me. Have you tested this with some polyglot-using app and 23.0?

No, I don't have any such app in mind.

CI runs with 23.0 seem to fail with:

Error:  Failed to execute goal on project quarkus-vertx-http-deployment: Could not resolve dependencies for project io.quarkus:quarkus-vertx-http-deployment:jar:999-SNAPSHOT: The following artifacts could not be resolved: io.quarkus:quarkus-resteasy-reactive-server-spi-deployment:jar:999-SNAPSHOT (absent): Could not find artifact io.quarkus:quarkus-resteasy-reactive-server-spi-deployment:jar:999-SNAPSHOT -> [Help 1]

But that seems unrelated to this PR, as it manifests in graalvm/mandrel#696 as well. Not sure why that's happening though will need to investigate.

gsmet

Let's sort out what I pointed out inline before thinking about merging.

gsmet · 2024-03-13T14:17:26Z

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/JarResultBuildStep.java

+            nativeImageRunnerBuildItem.getBuildRunner()
+                    .setup(processInheritIODisabled.isPresent() || processInheritIODisabledBuildItem.isPresent());


I think we tried hard to avoid calling this over and over? (ping @Karm as he was the one who fought this fight)

Is it possible to somehow get this information once and for all and propagate it to where it's needed?

gemmellr · 2024-03-13T14:42:03Z

Error:  Failed to execute goal on project quarkus-vertx-http-deployment: Could not resolve dependencies for project io.quarkus:quarkus-vertx-http-deployment:jar:999-SNAPSHOT: The following artifacts could not be resolved: io.quarkus:quarkus-resteasy-reactive-server-spi-deployment:jar:999-SNAPSHOT (absent): Could not find artifact io.quarkus:quarkus-resteasy-reactive-server-spi-deployment:jar:999-SNAPSHOT -> [Help 1]

But that seems unrelated to this PR, as it manifests in graalvm/mandrel#696 as well. Not sure why that's happening though will need to investigate.

There was a change that used an old module name, which then no longer exists for a new build, if the relocations arent also built. It was updated to the new name in #39398 a little while ago, after your run started on the old revision.

Mandrel 23.0 ships with org.graalvm.polyglot:polyglot embedded and adding it to the classpath results in an error.

zakkak · 2024-03-13T14:58:20Z

Thank you @gemmellr. I rebased and rescheduled a Mandrel 23.0 CI run: https://github.com/graalvm/mandrel/actions/runs/8267091725

quarkus-bot · 2024-03-13T19:24:07Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 4f06887.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✔️	JVM Tests - JDK 17			Logs	Raw logs	🚧
✖	JVM Tests - JDK 17 Windows	`Build`	Failures	Logs	Raw logs	🚧
✔️	JVM Tests - JDK 21			Logs	Raw logs	🚧

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/qute/deployment 
! Skipped: devtools/cli extensions/mailer/deployment extensions/resteasy-classic/resteasy-qute/deployment and 6 more

📦 extensions/qute/deployment

✖ io.quarkus.qute.deployment.devmode.NoRestartTemplatesDevModeTest.testNoRestartTemplates line 49 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <Hello f7ade625-b05d-4ffe-938b-cf93a82da4cc!!!> but was: <Hello 0fecb741-6f17-4589-92e9-ff4132485736!!!>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
	at io.quarkus.qute.deployment.devmode.NoRestartTemplatesDevModeTest.testNoRestartTemplates(NoRestartTemplatesDevModeTest.java:49)

Flaky tests - Develocity

⚙️ Maven Tests - JDK 17

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed - History

io.quarkus.maven.it.DevMojoIT expected "c19d1ec8-e685-46a6-861c-178f0fa7fd2e" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: io.quarkus.maven.it.DevMojoIT expected "c19d1ec8-e685-46a6-861c-178f0fa7fd2e" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:691)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

io.quarkus.maven.it.DevMojoIT expected "1544af78-256d-4d59-99df-ec87ab5a34de" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: io.quarkus.maven.it.DevMojoIT expected "1544af78-256d-4d59-99df-ec87ab5a34de" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:691)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

io.quarkus.maven.it.DevMojoIT expected "7ddce704-900c-4547-a76f-98b36dde9dae" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: io.quarkus.maven.it.DevMojoIT expected "7ddce704-900c-4547-a76f-98b36dde9dae" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:691)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

✖ io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed - History

io.quarkus.maven.it.DevMojoIT expected "c19d1ec8-e685-46a6-861c-178f0fa7fd2e" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: io.quarkus.maven.it.DevMojoIT expected "c19d1ec8-e685-46a6-861c-178f0fa7fd2e" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:691)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

io.quarkus.maven.it.DevMojoIT expected "1544af78-256d-4d59-99df-ec87ab5a34de" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: io.quarkus.maven.it.DevMojoIT expected "1544af78-256d-4d59-99df-ec87ab5a34de" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:691)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

io.quarkus.maven.it.DevMojoIT expected "7ddce704-900c-4547-a76f-98b36dde9dae" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: io.quarkus.maven.it.DevMojoIT expected "7ddce704-900c-4547-a76f-98b36dde9dae" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:691)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

zakkak · 2024-03-14T16:31:44Z

Closing in favor of #39442 as discussed in #39440 (comment)

zakkak requested a review from geoand March 13, 2024 11:20

zakkak changed the title ~~Remove org.graalvm.polyglot:polyglot when using Mandrel 23.0~~ Remove org.graalvm.polyglot:polyglot from classpath when using Mandrel 23.0 Mar 13, 2024

quarkus-bot bot added the area/core label Mar 13, 2024

zakkak added the triage/backport-3.8 label Mar 13, 2024

zakkak mentioned this pull request Mar 13, 2024

[Mandrel 23.0] hibernate-orm-panache-kotlin native integration tests fail with 23.0 build and 23.1.2 sdk. #39322

Closed

geoand approved these changes Mar 13, 2024

View reviewed changes

gsmet added the triage/backport label Mar 13, 2024

zakkak mentioned this pull request Mar 13, 2024

Replace org.graalvm.sdk:graal-sdk dependency with org.graalvm.sdk:nativeimage #39372

Merged

jerboaa reviewed Mar 13, 2024

View reviewed changes

gsmet requested changes Mar 13, 2024

View reviewed changes

Remove org.graalvm.polyglot:polyglot when using Mandrel 23.0

4f06887

Mandrel 23.0 ships with org.graalvm.polyglot:polyglot embedded and adding it to the classpath results in an error.

zakkak force-pushed the 2024-03-13-fix-39322 branch from 6a8a66f to 4f06887 Compare March 13, 2024 14:57

quarkus-bot bot added the triage/flaky-test label Mar 13, 2024

This was referenced Mar 14, 2024

Exception when building application with a lot of dependencies, String too large to record error #39350

Closed

graal-sdk in 23.1.x brings in org.graalvm.polyglot which causes a couple of issues (wrap up) #39440

Closed

zakkak closed this Mar 14, 2024

quarkus-bot bot added triage/invalid This doesn't seem right and removed triage/backport-3.8 triage/backport labels Mar 14, 2024

zakkak deleted the 2024-03-13-fix-39322 branch March 14, 2024 16:32

zakkak restored the 2024-03-13-fix-39322 branch March 14, 2024 16:32

zakkak deleted the 2024-03-13-fix-39322 branch March 27, 2024 10:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove `org.graalvm.polyglot:polyglot` from classpath when using Mandrel 23.0 #39397

Remove `org.graalvm.polyglot:polyglot` from classpath when using Mandrel 23.0 #39397

zakkak commented Mar 13, 2024

zakkak commented Mar 13, 2024 •

edited

Loading

jerboaa left a comment

zakkak commented Mar 13, 2024

gsmet left a comment

gsmet Mar 13, 2024

gemmellr commented Mar 13, 2024

zakkak commented Mar 13, 2024 •

edited

Loading

quarkus-bot bot commented Mar 13, 2024

zakkak commented Mar 14, 2024

		nativeImageRunnerBuildItem.getBuildRunner()
		.setup(processInheritIODisabled.isPresent() \|\| processInheritIODisabledBuildItem.isPresent());

Remove org.graalvm.polyglot:polyglot from classpath when using Mandrel 23.0 #39397

Remove org.graalvm.polyglot:polyglot from classpath when using Mandrel 23.0 #39397

Conversation

zakkak commented Mar 13, 2024

zakkak commented Mar 13, 2024 • edited Loading

jerboaa left a comment

Choose a reason for hiding this comment

zakkak commented Mar 13, 2024

gsmet left a comment

Choose a reason for hiding this comment

gsmet Mar 13, 2024

Choose a reason for hiding this comment

gemmellr commented Mar 13, 2024

zakkak commented Mar 13, 2024 • edited Loading

quarkus-bot bot commented Mar 13, 2024

Status for workflow Quarkus CI

Failing Jobs

Failures

⚙️ JVM Tests - JDK 17 Windows #

📦 extensions/qute/deployment

Flaky tests - Develocity

⚙️ Maven Tests - JDK 17

📦 integration-tests/maven

zakkak commented Mar 14, 2024

Remove `org.graalvm.polyglot:polyglot` from classpath when using Mandrel 23.0 #39397

Remove `org.graalvm.polyglot:polyglot` from classpath when using Mandrel 23.0 #39397

zakkak commented Mar 13, 2024 •

edited

Loading

zakkak commented Mar 13, 2024 •

edited

Loading

Status for workflow `Quarkus CI`