Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gRPC code generation to utilize argument file #39291

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

cescoffier
Copy link
Member

@cescoffier cescoffier commented Mar 8, 2024

This PR enables the gRPC code generation process to utilize an argument file. This approach helps prevent command length exceeding the operating system limit, particularly on platforms like Windows. This feature is automatically enabled on Windows if the command line exceeds 8191 characters.

This commit enables the gRPC code generation process to utilize an argument file. This approach helps prevent command length from exceeding the operating system limit, particularly on platforms such as Windows. This feature is automatically enabled on Windows if the command line exceeds 8191 characters.
@ia3andy
Copy link
Contributor

ia3andy commented Mar 8, 2024

@cescoffier I think you put the wrong issue id

Copy link

quarkus-bot bot commented Mar 8, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit b74353a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

github-actions bot commented Mar 8, 2024

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Mar 8, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b74353a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@cescoffier cescoffier merged commit d2b6b87 into quarkusio:main Mar 11, 2024
37 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Mar 11, 2024
@cescoffier cescoffier deleted the grpc-arg-file branch March 11, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

gRPC codegen fails for large file name like io.envoyproxy.controlplane:api on windows
3 participants