Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance TLS certificate alias and SNI handling (HTTP & gRPC) #39287

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

cescoffier
Copy link
Member

@cescoffier cescoffier commented Mar 8, 2024

This PR focuses on refining the handling of TLS certificates, specifically addressing issues related to aliases and Server Name Indication (SNI).

This PR includes:

  • Fixing gRPC TLS server configuration to support aliases and alias passwords properly.
  • Verifying gRPC handling of aliases for both clients and servers.
  • Ensuring HTTP (main and management) support for aliases.
  • Verifying HTTP server SNI support.

One limitation of SNI when using P12 or JKS is that all the aliases must use the same password.

This commit focuses on refining the handling of TLS certificates, specifically addressing issues related to aliases and Server Name Indication (SNI).

This commit includes:
- Fixing gRPC TLS server configuration to properly support aliases and alias passwords.
- Verifying gRPC handling of aliases for both clients and servers.
- Ensuring HTTP (main and management) support for aliases.
- Verifying HTTP server SNI support.
@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/grpc gRPC area/vertx labels Mar 8, 2024
@cescoffier
Copy link
Member Author

@geoand We would need the same kind of tests once we have full TLS support on the reactive rest client (by full support I means all formats and options)

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 8, 2024
Copy link

quarkus-bot bot commented Mar 8, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 708a70f.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.dev.KafkaDevServicesDevModeTestCase.sseStream - History

  • Assertion condition Expecting size of: [] to be greater than or equal to 2 but was 0 within 10 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: 
Assertion condition 
Expecting size of:
  []
to be greater than or equal to 2 but was 0 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)

@cescoffier cescoffier merged commit fc5df7c into quarkusio:main Mar 8, 2024
49 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Mar 8, 2024
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 8, 2024
@cescoffier cescoffier deleted the new-cert-gen branch March 11, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/grpc gRPC area/vertx triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants