Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sending Multi<io.vertx.mutiny.core.buffer.Buffer> in REST Client #39285

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 8, 2024

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Mar 8, 2024

I would appreciate if we slowed down a bit on RESTEasy Reactive/REST Client PRs as rebasing is not so easy.

@geoand
Copy link
Contributor Author

geoand commented Mar 8, 2024

Not a problem at all

@geoand
Copy link
Contributor Author

geoand commented Mar 8, 2024

I had not realized that Git couldn't handle these... Sorry

This comment has been minimized.

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Mar 9, 2024

I had not realized that Git couldn't handle these... Sorry

I think most of the problems are when new files are added. AFAICS it can actually handle it nowadays, at least it seems it reports a conflict but with the new files moved to the appropriate directory.

So it doesn't look that big of a deal (if I understood things correctly), it's just a bit stressful as you're never really sure :).

Hopefully, the big REST renaming PR will get merged soon.

@geoand
Copy link
Contributor Author

geoand commented Mar 9, 2024

Hopefully, the big REST renaming PR will get merged soon.

I'll have a look at it first thing on Monday!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 11, 2024
Copy link

quarkus-bot bot commented Mar 11, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b5f3394.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit 5c25ff5 into quarkusio:main Mar 11, 2024
42 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Mar 11, 2024
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Mar 11, 2024
@geoand
Copy link
Contributor Author

geoand commented Mar 11, 2024

I still need to add a note in the documentation about this - I'll do that soon

@geoand geoand deleted the #20024 branch March 12, 2024 06:43
geoand added a commit to geoand/quarkus that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rest kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Multi<Byte> and Multi<byte[]> for octet stream in Rest Client Reactive
4 participants