-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support sending Multi<io.vertx.mutiny.core.buffer.Buffer> in REST Client #39285
Conversation
This comment has been minimized.
This comment has been minimized.
I would appreciate if we slowed down a bit on RESTEasy Reactive/REST Client PRs as rebasing is not so easy. |
Not a problem at all |
I had not realized that Git couldn't handle these... Sorry |
...t-reactive/deployment/src/test/java/io/quarkus/rest/client/reactive/SendMultiBufferTest.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I think most of the problems are when new files are added. AFAICS it can actually handle it nowadays, at least it seems it reports a conflict but with the new files moved to the appropriate directory. So it doesn't look that big of a deal (if I understood things correctly), it's just a bit stressful as you're never really sure :). Hopefully, the big REST renaming PR will get merged soon. |
I'll have a look at it first thing on Monday! |
Status for workflow
|
I still need to add a note in the documentation about this - I'll do that soon |
Multi<Byte>
andMulti<byte[]>
for octet stream in Rest Client Reactive #20024