Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve OIDC tenants with path-matching configuration as alternative to TenantResolver #39236

Merged

Conversation

michalvavrik
Copy link
Member

closes: #33495

@michalvavrik michalvavrik force-pushed the feature/oidc-tenant-path-matching branch 2 times, most recently from cfb7aae to aad3f58 Compare March 6, 2024 22:02

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/oidc-tenant-path-matching branch from aad3f58 to db44a4e Compare March 6, 2024 22:20

This comment has been minimized.

Copy link

github-actions bot commented Mar 6, 2024

🙈 The PR is closed and the preview is expired.

@michalvavrik michalvavrik requested a review from sberyozkin March 6, 2024 23:16

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/oidc-tenant-path-matching branch from db44a4e to d64d089 Compare March 10, 2024 18:58

This comment has been minimized.

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/oidc-tenant-path-matching branch 2 times, most recently from 03494ea to b44cd0e Compare March 11, 2024 11:27

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/oidc-tenant-path-matching branch from b44cd0e to 39afabd Compare March 11, 2024 11:41

This comment has been minimized.

This comment has been minimized.

@michalvavrik michalvavrik force-pushed the feature/oidc-tenant-path-matching branch from 39afabd to db379cf Compare March 11, 2024 16:02
Copy link

quarkus-bot bot commented Mar 11, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit db379cf.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michalvavrik.

Copy link

quarkus-bot bot commented Mar 11, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit db379cf.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.


Flaky tests - Develocity

⚙️ Maven Tests - JDK 17

📦 integration-tests/maven

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed - History

  • io.quarkus.maven.it.DevMojoIT expected "bbf9ba8e-7879-4c2a-a3b1-347a09031880" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: io.quarkus.maven.it.DevMojoIT expected "bbf9ba8e-7879-4c2a-a3b1-347a09031880" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:691)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed - History

  • io.quarkus.maven.it.DevMojoIT expected "bbf9ba8e-7879-4c2a-a3b1-347a09031880" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: io.quarkus.maven.it.DevMojoIT expected "bbf9ba8e-7879-4c2a-a3b1-347a09031880" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:691)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@sberyozkin sberyozkin merged commit 9d46911 into quarkusio:main Mar 12, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Mar 12, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Mar 12, 2024
@michalvavrik michalvavrik deleted the feature/oidc-tenant-path-matching branch March 12, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

OIDC tenant resolution policy
2 participants